Skip to content
This repository has been archived by the owner on Apr 12, 2023. It is now read-only.

Support adaptive icon #367

Merged
merged 2 commits into from Feb 25, 2022
Merged

Support adaptive icon #367

merged 2 commits into from Feb 25, 2022

Conversation

keiji
Copy link
Collaborator

@keiji keiji commented Sep 5, 2021

Issue 番号 / Issue ID

目的 / Purpose

  • Adaptive Iconに対応して見た目を良くする

Adaptive Icon未対応

Screenshot_20210906-083639

Adaptive Icon対応

Screen Shot 2021-09-06 at 1 02 08

破壊的変更をもたらしますか / Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request の種類 / Pull Request type

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

検証方法 / How to test

コードの入手 / Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
dotnet restore

コードの検証 / Test the code


確認事項 / What to check

  • API Level 26以上でアダプティブアイコンが正常に表示される
  • API Level 25以下で画像アイコンが正常に表示される

その他 / Other information

厚生労働省のシンボルマーク利用に関わるので調整の必要があります。
よろしくお願いいたします。

@keiji keiji self-assigned this Sep 5, 2021
@keiji keiji marked this pull request as ready for review September 5, 2021 23:51
@keiji keiji marked this pull request as draft September 28, 2021 07:03
@keiji keiji marked this pull request as ready for review September 28, 2021 13:48
@cocoa-dev003
Copy link
Contributor

レビュー完了しました、問題ないです!
本PRは次バージョンには含めないので、Approve, Marge は後日実施します。

@ghost
Copy link

ghost commented Feb 17, 2022

@keiji
お手数おかけしますが、コンフリクトの解消をお願いします。

@cocoa-dev005 cocoa-dev005 merged commit d9f6fea into cocoa-mhlw:develop Feb 25, 2022
@cocoa-dev005
Copy link
Contributor

LGTM :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Adaptive Icon対応
3 participants