Skip to content
This repository has been archived by the owner on Mar 5, 2023. It is now read-only.

Removed deployment_target from Podspec #47

Merged
merged 1 commit into from
Mar 15, 2016

Conversation

@shpakovski
Copy link
Collaborator

Thank you for the heads up! Why not 10.6?

@josh64x2
Copy link
Contributor Author

I think it is OK to leave it blank. https://guides.cocoapods.org/syntax/podspec.html#deployment_target says this if it is blank then it will assume it works on OS X < 10.8 as well.

I looked at a couple of other cocoapods that we use and they all left it blank.

Thank you for your work with MASPreferences!

shpakovski pushed a commit that referenced this pull request Mar 15, 2016
Removed deployment_target from Podspec
@shpakovski shpakovski merged commit f70296c into cocoabits:master Mar 15, 2016
@shpakovski
Copy link
Collaborator

Thanks for the PR!

@mackuba
Copy link

mackuba commented Mar 20, 2016

@josh64x2 thanks!

@shpakovski can you push the updated podspec to CocoaPods?

@shpakovski
Copy link
Collaborator

@mackuba Yes, could you please advise how do I do this?

  1. Bump the tag string "1.1.2" to "1.1.3" with a new master commit
  2. Then attach the tag 1.1.3 to that commit and push it to origin
  3. Make a PR to update the tag to the new version in CocoaPods

Correct? Is this enough?

@josh64x2 josh64x2 deleted the podspec-fix branch March 21, 2016 08:07
@josh64x2
Copy link
Contributor Author

@shpakovski I would change the version number in the Podspec to 1.1.3 as well, and then follow the instructions from here: https://guides.cocoapods.org/making/specs-and-specs-repo.html

How do I update an existing Pod?

  1. Create your Podspec as described above.
    
  2. Run `pod spec lint` to check for errors.
    
  3. Submit your Podspec to Trunk with `pod trunk push NAME.podspec`
    

I've never done it before so this is just a guess 😄

@shpakovski
Copy link
Collaborator

Alright, I updated repository for the new version, but pod trunk push MASPreferences.podspec gives an error [!] Authentication token is invalid or unverified. Either verify it with the email that was sent or register a new session. I don't remember how I did this last time, sorry 😅

@josh64x2
Copy link
Contributor Author

Haha what a helpful error. Try this : https://guides.cocoapods.org/making/getting-setup-with-trunk.html 😊

@shpakovski
Copy link
Collaborator

It worked! Thank you so much Josh. Could you please verify the new version?

@josh64x2
Copy link
Contributor Author

It works here 😄 thanks for the quick response!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants