Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest Build Breaks Settings! #156

Closed
philosopherdog opened this issue Feb 22, 2023 · 4 comments
Closed

Latest Build Breaks Settings! #156

philosopherdog opened this issue Feb 22, 2023 · 4 comments

Comments

@philosopherdog
Copy link
Contributor

philosopherdog commented Feb 22, 2023

4196a173faf36b40857509e84a67748ee7337ffa removes the settings functionality. I've done a PR to partially fix this. Mean while feel free to point to my fork https://github.com/philosopherdog/CocoaDebug/tree/settings-fix which includes the swift5 updates. @CocoaDebug Actually there's a lot of random stuff just being removed without documenting why. Eg. enableLogMonitoring no longer works! So I wouldn't use 175 personally. I recommend just pointing to https://github.com/philosopherdog/CocoaDebug/tree/swift5 as it has all the changes from 175 but none of the breaking stuff.

@CocoaDebug
Copy link
Owner

Thanks. I just want to remove some cumbersome function. Make CocoaDebug simple.

@CocoaDebug
Copy link
Owner

CocoaDebug commented Mar 1, 2023

enableLogMonitoring is not needed, You can just enable/disable Network/Logs monitoring on CocoaDebug panel with switch button. @philosopherdog

@philosopherdog
Copy link
Contributor Author

@CocoaDebug Personally I would revert most of 4196a173faf36b40857509e84a67748ee7337ffa commit. I do use settings. I think this doesn't really improve the library to remove any of these things IMO. It would be good to do some code review on these PR's to catch any questionable changes. This way you get some more eyes on the changes before they get merged. What do you think?

@CocoaDebug
Copy link
Owner

CocoaDebug commented Mar 3, 2023

I have revert and published a new version. Thanks. @philosopherdog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants