Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@"list-style" -> @"list-style-type" #60

Closed
dhoerl opened this issue Aug 10, 2011 · 4 comments
Closed

@"list-style" -> @"list-style-type" #60

dhoerl opened this issue Aug 10, 2011 · 4 comments

Comments

@dhoerl
Copy link
Contributor

dhoerl commented Aug 10, 2011

In DTHTMLElement.m, this line:

NSString *listStyleStr = [[styles objectForKey:@"list-style"] lowercaseString];

should instead be:

NSString *listStyleStr = [[styles objectForKey:@"list-style-type"] lowercaseString];

Once I made this change then my lists got the proper bullets.

@odrobnik
Copy link
Collaborator

Please send pull requests with changes you made so that I can easily merge them and you get attribution for them.

On Aug 10, 2011, at 1:54 PM, dhoerl wrote:

In DTHTMLElement.m, this line:

NSString *listStyleStr = [[styles objectForKey:@"list-style"] lowercaseString];

should instead be:

NSString *listStyleStr = [[styles objectForKey:@"list-style-type"] lowercaseString];

Once I made this change then my lists got the proper bullets.

Reply to this email directly or view it on GitHub:
https://github.com/Cocoanetics/NSAttributedString-Additions-for-HTML/issues/60

Oliver Drobnik
oliver@drobnik.com

@odrobnik
Copy link
Collaborator

Reason: somebody (probably me if no other smart person volunteers) needs to implement the correct parsing of list-style which is a short version of writing out the items of the sub-types in one line.

On Aug 10, 2011, at 1:54 PM, dhoerl wrote:

In DTHTMLElement.m, this line:

NSString *listStyleStr = [[styles objectForKey:@"list-style"] lowercaseString];

should instead be:

NSString *listStyleStr = [[styles objectForKey:@"list-style-type"] lowercaseString];

Once I made this change then my lists got the proper bullets.

Reply to this email directly or view it on GitHub:
https://github.com/Cocoanetics/NSAttributedString-Additions-for-HTML/issues/60

Oliver Drobnik
oliver@drobnik.com

@dhoerl
Copy link
Contributor Author

dhoerl commented Aug 10, 2011

On 8/10/11 8:31 AM, Cocoanetics wrote:

Reason: somebody (probably me if no other smart person volunteers) needs to implement the correct parsing of list-style which is a short version of writing out the items of the sub-types in one line.

I'm working on getting a proper fork so I can do a pull request on this.
I'd be glad to help out with the parsing but not quite sure what you
need done, as you appear to have most of this coded now.

But, given how much this framework is helping me, I'd be glad to help
out where possible.

David

@dhoerl
Copy link
Contributor Author

dhoerl commented Aug 10, 2011

OK - I did the pull request. I also added two options to attributedString defaults for two indention properties.

I'd be glad to do the init-style work .

@dhoerl dhoerl closed this as completed Aug 10, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants