Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Specification] Use string for all the keys #112

Closed
fabiopelosin opened this issue Apr 16, 2014 · 2 comments
Closed

[Specification] Use string for all the keys #112

fabiopelosin opened this issue Apr 16, 2014 · 2 comments
Assignees

Comments

@fabiopelosin
Copy link
Member

Currently the sub keys of the hashes use symbols (e.g. source the source params like :git). There is already logic there to handle the conversion when appropriate... but all the keys should be used as strings and converted, if needed, by the consumer.

This would also lead to a cleaner Lockfile:

EXTERNAL SOURCES:
  IFBKCampground:
    :git: https://github.com/irrationalfab/IFBKCampground.git
  IFBKThirtySeven:
    :path: ../../IFBKThirtySeven
  IRFAutoCompletionKit:
    :git: https://github.com/irrationalfab/IRFAutoCompletionKit
  IRFNavigationKit:
    :git: https://github.com/irrationalfab/IRFNavigationKit.git)

Related: CocoaPods/CocoaPods#1058 (comment)

@alloy we need to double check this for trunk because the JSON podspec return strings.

@alloy
Copy link
Member

alloy commented Apr 16, 2014

A string and a symbol are semantically (outside of Ruby) the same, so I don’t think it’s a real problem in trunk, unless I’m not understanding what you think the problem might be?

Maybe you can look into HashWithIndifferentAccess (from Activesupport) to see if it allows you to easily convert a Hash to a Hash with all symbol keys.

@fabiopelosin fabiopelosin self-assigned this Jul 25, 2014
@fabiopelosin
Copy link
Member Author

Actually this is not proving to be an issue, so I'm closing it until evidenced that this is needed is found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants