Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable use of cog verify in action #10

Merged
merged 1 commit into from
May 14, 2024

Conversation

the-wondersmith
Copy link
Contributor

PR adds support for using cocogitto's verify functionality as part of a down-stream Action

@the-wondersmith
Copy link
Contributor Author

@oknozor 👋 hello again 😅

@oknozor
Copy link
Collaborator

oknozor commented Jul 8, 2023

@oknozor wave hello again sweat_smile

Hey @the-wondersmith
thanks for the PR. I'll be away for a week, I'll take a look as soon as I am back.

@the-wondersmith
Copy link
Contributor Author

@oknozor wave hello again sweat_smile

Hey @the-wondersmith thanks for the PR. I'll be away for a week, I'll take a look as soon as I am back.

@oknozor Shameless self bump

@the-wondersmith
Copy link
Contributor Author

@oknozor Bump

@oknozor
Copy link
Collaborator

oknozor commented Aug 17, 2023

Hey @the-wondersmith I am back, can you rebase this on main so I can merge and release ?

@the-wondersmith
Copy link
Contributor Author

@oknozor Upstream changes pulled in, merge at will 😁

@oknozor
Copy link
Collaborator

oknozor commented Sep 27, 2023

Sorry @the-wondersmith, I just updated the version and there are conflicts again, can you rebase locally so I can merge this ?

@cocogitto-bot
Copy link

cocogitto-bot bot commented Sep 27, 2023

✔️ 19ee671...8a406a5 - Conventional commits check succeeded.

@the-wondersmith
Copy link
Contributor Author

@oknozor done and done 😁

@oknozor
Copy link
Collaborator

oknozor commented Sep 28, 2023

I can't merge, still seeing some conflict. But this seems to be a bug on github.

@the-wondersmith
Copy link
Contributor Author

@oknozor Sorry this apparently took me so long to get back to 😅. Conflicts should be resolved now.

@the-wondersmith
Copy link
Contributor Author

@oknozor bump

@oknozor
Copy link
Collaborator

oknozor commented May 14, 2024

@the-wondersmith, the bug is still there:
image

Can you reopen the same PR from another branch ?

Signed-off-by: Mark S <the@wondersmith.dev>
@the-wondersmith
Copy link
Contributor Author

@oknozor rebased locally and force-pushed it (should be just one commit of difference now 😁)

screenshot

@oknozor oknozor merged commit 8847c89 into cocogitto:main May 14, 2024
@oknozor
Copy link
Collaborator

oknozor commented May 14, 2024

hooray ! I will make a version tomorrow :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants