-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Allow the tag format to be configured #122
Comments
Hey @yourfate, thanks for the suggestion. As you said the I will implement it but I will not make this mandatory since this would break existing repo not using this convention, including cocogitto itself (see: SemVer FAQ). Would you be ok with a config attribute in cog.toml like : tag_prefix = "v" This would be easy to implement and a non breaking change. |
Sounds good. I would still suggest making it default, allowing it to be configured "off". |
@oknozor i'm down to work on this change if that's cool, not sure if you want to wait for new release or not first. |
@its-danny I am already working on this, sorry. |
Is your feature request related to a problem? Please describe.
Our verison tags for all projects use the format
v2.3.7
, note thev
. This has advantages when filtering tags with the glob ofgit describe --match
, asv*.*.*
is a lot better of a glob than*.*.*
, which would also match likebugfix-for-2.3.7-problem-x
or some other custom tags we use.It allows us to mention versions in tags without those tags being matched for things that extract the latest version tag from the history.
cog doesn't seem to recognize our tags though.
Describe the solution you'd like
Make the tag format configurable, or maybe even switch to the
v*.*.*
tag style entirely.Note: the
v*.*.*
tags format is the default on Gitlab, it's pre-configured as protected and used by them to version gitlab itself, too. Other large projects like git or linux also use this format. Even semver themselves use it.The text was updated successfully, but these errors were encountered: