-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] [Monorepo] Add a config attribute to set if a global tag should be generated #259
Comments
Hello @Wassim-AB,
That's not exactly how it works. Packages with
100% agree here, I started with this behavior as the default one, but we really need a config flag to set whether or not a global tag should be generated. If you decide to not generate a global tag then I'll implement this asap, probably next week. Thanks |
Hello @oknozor, Thank you for taking this into consideration ! :) |
* feat(monorepo): add config opt to disable global global-tag-opt * refactor: use builder pattern for hook run options * chore: remove codesee * chore: add andre161292 to contributors list Closes #259
Hello,
I have a GitHub repository on which I store Helm Charts and I'm trying to use Cocogitto to manage my Chart's versions.
I made a public repository on which I reproduced my configuration to illustrate the issue I face :
https://github.com/Wassim-AB/cog-test
I have two Helm Charts, Jenkins and Thumbor, that I created in separated commits respectively with the
feat(jenkins)
and thefeat(thumbor)
prefixes.Then, I added the Cocogitto configuration file using a
chore
commit. Because my repository is only supposed to store the Helm Charts, I set thepublic_api
attribute of my packages tofalse
since it doesn't make sense for my repository to have a global tag.I then executed the
cog bump --auto --dry-run
command to see what tags Cocogitto would create, but instead I got this error message :However, when I remove the
public_api=false
attribute of one of my packages, I get this :My supposition is that Cocogitto won't bump packages if they all have the
public_api=false
attribute, but it doesn't always make sense for a Monorepo to have a global version since sometimes you just store packages that are related in terms of purpose but not in terms of dependencies.Is this behavior desired or is it a bug ?
Thank you in advance for your time !
Wassim.
Related feature: #232
The text was updated successfully, but these errors were encountered: