Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bump): support annotated tags #261

Merged
merged 1 commit into from Feb 17, 2023
Merged

feat(bump): support annotated tags #261

merged 1 commit into from Feb 17, 2023

Conversation

bitfehler
Copy link
Contributor

Many projects use annotated commits for their releases. This commit extends cog bump with the -A MSG/--annoted MSG argument, which will create an annotated tag with the tag message MSG.

Much like the bump hooks, {{version}} and {{latest}} can be used in the provided tag message and will be replaced accordingly.

@ghost
Copy link

ghost commented Feb 11, 2023 •
edited by ghost

👇 Click on the image for a new way to code review

  • Make big changes easier — review code in small groups of related files

  • Know where to start — see the whole change at a glance

  • Take a code tour — explore the change with an interactive tour

  • Make comments and review — all fully sync’ed with github

    Try it now!

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

@bitfehler
feat(bump): support annotated tags
1a90a11 
Many projects use annotated commits for their releases. This commit
extends `cog bump` with the `-A MSG`/`--annoted MSG` argument, which
will create an annotated tag with the tag message `MSG`.

Much like the bump hooks, `{{version}}` and `{{latest}}` can be used in
the provided tag message and will be replaced accordingly.
@cocogitto-bot
Copy link

cocogitto-bot bot commented Feb 13, 2023

✔️ 1a90a11 - Conventional commits check succeeded.

@bitfehler
Copy link
Contributor Author

Sorry for the test failure, mixed up Tag::create() and ::create_tag() in one branch 😬

Should be fixed now.

@bitfehler
Copy link
Contributor Author

Hm, the test failure is now a failure to upload the code coverage report, so seems unrelated to my changes?

@oknozor
Copy link
Collaborator

oknozor commented Feb 13, 2023

Hey @bitfehler, thanks for the PR! This is definitely a welcome addition to cocogitto.
I'll do a proper review during the week. I am busy right now. Sorry to keep you waiting a bit longer.

Hm, the test failure is now a failure to upload the code coverage report, so seems unrelated to my changes ?

Yes don't worry that something I need to fix but it won't be blocking this PR.

@oknozor oknozor merged commit 363387d into cocogitto:main Feb 17, 2023
@oknozor
Copy link
Collaborator

oknozor commented Feb 17, 2023

Thank you @bitfehler !

@oknozor oknozor mentioned this pull request Feb 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bitfehler @oknozor