Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): show repo and current tag name in "cog log" #54

Conversation

renaultfernandes
Copy link
Contributor

I've made changes to cog log so that it uses "repo_name:latest_tag" instead of the string "cog log" as the file name to pager.

Open Questions:

  1. Should we include the current branch name as well. If yes, how should the text be formatted?
  2. If there is no tag in the repo, then we only display the repo name. This behavior should be alright, right?
  3. I've added code to use the string "cog log" just in case something goes wrong. Should I get rid of it or could you please suggest a better approach to handle this.

Closes #47

@oknozor
Copy link
Collaborator

oknozor commented Oct 10, 2020

Hello @renaultfernandes thank you for taking this one !
You could add your git signature/github username to cog.toml (in this PR).

1. Should we include the current branch name as well. If yes, how should the text be formatted?

That would be great ! Something like {repo_name} on {branch} {tag} would do I guess.

2. If there is no tag in the repo, then we only display the repo name. This behavior should be alright, right?

Yep.

3. I've added code to use the string "cog log" just in case something goes wrong. Should I get rid of it or could you please suggest a better approach to handle this.

Seems good to me.

I will merge when you complete those little changes.

@renaultfernandes
Copy link
Contributor Author

Thanks for reviewing my PR. I've made the suggested changes.
Cheers !!!

@oknozor oknozor merged commit dcd28e8 into cocogitto:master Oct 11, 2020
@oknozor
Copy link
Collaborator

oknozor commented Oct 11, 2020

Congrats @renaultfernandes, nice one !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] - Show current branch/tag name instead of "cog log" in cog log
2 participants