Update bitflags crate to 2.4.0
#80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
00xc
approved these changes
Aug 29, 2023
|
Can we also remove the warning suppression in this PR? This would need to be done in the Github Actions yaml and the pre-commit hook. |
Ooops, I completely forgot about them. Sure, so I'll add a new commit to this PR removing those suppressions! |
Commit a94d48d ("SVSM/sev/utils: Suppress clippy::bad_bit_mask errors") was necessary because we use an older version of bitflags. As suggested in this [1] bitflags issue, let's switch to the latest version available. In this way we can avoid to suppress clippy::bad_bit_mask. Just minor adjustments are needed to support bitflags 2.4.0. [1] bitflags/bitflags#373 Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
With the new version of `bitflags` we no longer need to suppress the `clippy::bad_bit_mask` warnings. Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
stefano-garzarella
force-pushed
the
bitflags-2
branch
from
20c5cb7
to
58b9635
Compare
|
v2:
|
|
Looks good to me, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit a94d48d ("SVSM/sev/utils: Suppress clippy::bad_bit_mask errors") was necessary because we use an older version of bitflags. As suggested in this [1] bitflags issue, let's switch to the latest version available. In this way we can avoid to suppress clippy::bad_bit_mask.
Just minor adjustments are needed to support bitflags 2.4.0.
[1] bitflags/bitflags#373