Merge pull request #537 from cocopon/merge-v318

Merge changes in v3.1.8
cocopon · Apr 18, 2023 · 1153187 · 1153187
2 parents 21f7b07 + b7f5e75
commit 1153187
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "tweakpane-monorepo",
-  "version": "3.1.7",
+  "version": "3.1.8",
   "private": true,
   "description": "Tweakpane monorepo",
   "author": "cocopon",

diff --git a/packages/core/package.json b/packages/core/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@tweakpane/core",
-  "version": "1.1.6",
+  "version": "1.1.7",
   "description": "Tweakpane core library",
   "author": "cocopon",
   "license": "MIT",

diff --git a/packages/core/src/common/binding/target-test.ts b/packages/core/src/common/binding/target-test.ts
@@ -22,4 +22,22 @@ describe(BindingTarget.name, () => {
 		target.write('wrote');
 		assert.strictEqual(obj.foo, 'wrote');
 	});
+
+	it('should bind static class field', () => {
+		class Test {
+			static foo = 1;
+		}
+
+		assert.doesNotThrow(() => {
+			new BindingTarget(Test, 'foo');
+		});
+	});
+
+	it('should determine class is bindable', () => {
+		class Test {
+			static foo = 1;
+		}
+
+		assert.strictEqual(BindingTarget.isBindable(Test), true);
+	});
 });
diff --git a/packages/core/src/common/binding/target.ts b/packages/core/src/common/binding/target.ts
@@ -24,7 +24,7 @@ export class BindingTarget {
 		if (obj === null) {
 			return false;
 		}
-		if (typeof obj !== 'object') {
+		if (typeof obj !== 'object' && typeof obj !== 'function') {
 			return false;
 		}
 		return true;

diff --git a/packages/tweakpane/package.json b/packages/tweakpane/package.json
@@ -1,6 +1,6 @@
 {
   "name": "tweakpane",
-  "version": "3.1.7",
+  "version": "3.1.8",
   "description": "A compact pane for fine-tuning parameters and monitoring value changes",
   "author": "cocopon",
   "license": "MIT",