Fix bug in class bindability detection, #534

cocopon · Apr 8, 2023 · d0934e8 · d0934e8
1 parent 03bbd12
commit d0934e8
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/packages/core/src/common/binding/target-test.ts b/packages/core/src/common/binding/target-test.ts
@@ -29,4 +29,22 @@ describe(BindingTarget.name, () => {
 		target.write('wrote');
 		assert.strictEqual(obj.foo, 'wrote');
 	});
+
+	it('should bind static class field', () => {
+		class Test {
+			static foo = 1;
+		}
+
+		assert.doesNotThrow(() => {
+			new BindingTarget(Test, 'foo');
+		});
+	});
+
+	it('should determine class is bindable', () => {
+		class Test {
+			static foo = 1;
+		}
+
+		assert.strictEqual(BindingTarget.isBindable(Test), true);
+	});
 });
diff --git a/packages/core/src/common/binding/target.ts b/packages/core/src/common/binding/target.ts
@@ -20,7 +20,7 @@ export class BindingTarget {
 		if (obj === null) {
 			return false;
 		}
-		if (typeof obj !== 'object') {
+		if (typeof obj !== 'object' && typeof obj !== 'function') {
 			return false;
 		}
 		return true;