Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Folder doesn't resize after disposing child/input #41

Closed
abolfazlshirazi opened this issue May 3, 2020 · 2 comments
Closed

Folder doesn't resize after disposing child/input #41

abolfazlshirazi opened this issue May 3, 2020 · 2 comments
Labels

Comments

@abolfazlshirazi
Copy link

Hi,
When I dispose some elements, they will disappear and the other items below it shift up and it is fine. But the height of the pane won't be updated so there will be an empty space at the end of the pane in a folder.

Untitled-2

@abolfazlshirazi abolfazlshirazi changed the title Folder doesn't resize after disposing child/input in a folder Folder doesn't resize after disposing child/input May 3, 2020
@abolfazlshirazi
Copy link
Author

I realized the followings solve the issue. However, it is just a temporary solution:

// rPane: The desired pane that you have
// ind: the index of the folder in the pane which you want to fix the height issue

var ind = 0;
var curH = rPane.controller.ucList_.items[ind].computeExpandedHeight_(); 
rPane.controller.ucList_.items[ind].view.folder_.expandedHeight_ = curH;
rPane.controller.ucList_.items[ind].folder.expandedHeight_ = curH;
rPane.refresh();
// You need to expand/collapse it once to make it work
rPane.controller.ucList_.items[ind].folder.expanded = false;
rPane.controller.ucList_.items[ind].folder.expanded = true;

@cocopon
Copy link
Owner

cocopon commented May 15, 2020

Fixed in #43. Thank you for reporting the issue and please wait for the next release!

@cocopon cocopon closed this as completed May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants