Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port label vertical alignment fix #3692

Merged
merged 1 commit into from
Jan 3, 2019

Conversation

id-ilych
Copy link
Contributor

Re: cocos-creator/2d-tasks#886

Port of #3664 for 1.10 release

image

Changes:

  • 完善 label 垂直对齐问题

@id-ilych id-ilych changed the title Port label vertical alignment fix ( Port label vertical alignment fix Dec 28, 2018
@pandamicro pandamicro merged commit 0e634c0 into cocos:v1.10-release Jan 3, 2019
@pandamicro
Copy link
Contributor

@id-ilych Thanks, sorry that we don't have recent plan to release any new 1.x version, you will need to use customized engine by yourself. By the way, why haven't you upgraded to v2.0 ?

@id-ilych
Copy link
Contributor Author

id-ilych commented Jan 9, 2019

@pandamicro I'm planning transition to 2.1 but there are a lot of things to do for that. Just to name few:

  1. Adopt API changes (e. g. rotation -> angle, cascadeOpacity -> nothing, sound engine is no longer taking string and is expecting sound clip now)
  2. Handle implicit behavior changes (e. g. emit no longer wraps the argument in cc.Event.EventCustom so subscriber should know whether event would be dispatched or emitted or to wrap all emits with explicit wrappings)
  3. CSV asset is handled differently in regards to line endings so I'll replace them with JSON assets.
  4. Fix all prefabs as migrations breaks a lot (e. g. spine premultipliedAlpha property is reset, scale property is reset)
  5. Test my app thoroughly as other breaking changes may be unknown.
  6. Minor things like fixing creator.d.ts (e. g. contains returns void instead of boolean, getCurrent accepts argument of type void instead of number).

So eventually I will do. But it will take some time :(
Though it probably worth it as performance boost is significant (2x time with some quick benchmark)

@id-ilych id-ilych deleted the v1.10-release branch January 9, 2019 19:14
@jareguo
Copy link
Contributor

jareguo commented Jan 17, 2019

@id-ilych Please only transit to 2.0.x because 2.1.0 is not very stable by now. We will keep update 2.0.x until 2.1 is stable enough.

@id-ilych
Copy link
Contributor Author

@jareguo Ok. Is there any estimation when 2.0.x will be released with similar ttf.js fix? I only see it in v2.1-release branch.

@Ronsku
Copy link

Ronsku commented Mar 19, 2019

@id-ilych @jareguo Will this fix be in 2.1.1? Currently I have to build each project with a separate engine and since engine settings in cocos are global, you have to change it every time you swap between projects that use different versions of Cocos Creator. Having this in 2.1.1 would be so nice!

Thank you!

@id-ilych
Copy link
Contributor Author

id-ilych commented Mar 19, 2019

@Ronsku I am not a part of CC team. Just an occasional contributor :) As jareguo mentioned earlier in this topic 2.1 is not recommended to be used in production yet. So what I can recommend to increase probability of this fix being included in future 2.0.x release is to create new pull request against v2.0-release branch. Unfortunatelly I can't do it right now but it seems to be trivial using original PR (#3664). And until project-specific custom engine configuration is fixed (it is in the UI but doesn't work) maybe it's better to use 2.0-based custom version of the engine for all the projects and migrate them synchronously to avoid the issue. I do understand that this could be problematic but it's best idea I have right now and that is what I personally do at work.

@jareguo
Copy link
Contributor

jareguo commented Mar 20, 2019

Is there any estimation when 2.0.x will be released with similar ttf.js fix? I only see it in v2.1-release branch.

No, 2.0.x will not have this larger adjustment.

@jareguo
Copy link
Contributor

jareguo commented Mar 20, 2019

Will this fix be in 2.1.1

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants