Remove reorder logic during walk #4926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoneLau
reviewed
Jul 20, 2019
cocos/renderer/ui/ui.ts
Outdated
| let node = resortNodeList[i]; | ||
| let children = node.children; | ||
| for (let i = 0; i < children.length; ++i) { | ||
| let node = children[i]; |
There was a problem hiding this comment.
这里之前的写法是不是不好，node 已经作为传入值，这里又声明了一个 let node = children[i]
JoneLau
reviewed
Jul 20, 2019
| @@ -78,6 +79,7 @@ export class UIComponent extends Component { | |||
| public onEnable () { | |||
| this._lastParent = this.node.parent; | |||
| this._updateVisibility(); | |||
| this._sortSiblings(); | |||
JoneLau
approved these changes
Jul 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: cocos-creator/2d-tasks#1145