Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine code for audioEngine recycleAudio #5097

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@umbrellaPP
Copy link
Contributor

commented Aug 6, 2019

避免 销毁 _audioPool 里实例的隐患

@2youyou2 2youyou2 merged commit df4ea7c into cocos-creator:v2.1.3 Aug 6, 2019
1 check passed
1 check passed
ci/circleci: test Your tests passed on CircleCI!
Details
jareguo added a commit that referenced this pull request Aug 6, 2019
* commit 'f0d6e0960adf7bf353cbd903219aafc01d5c7b9b':
  Improve localization (#4450)
  cherry pick: valueType add rotateAround func (#4642)
  refine api doc (#5099)
  refine code for audioEngine recycleAudio (#5097)
  simplify attribute implements (#5040)
  revert Label reset assembler (#5093)
  Lifecycle: optimize performance when eval is not available (#5058)

# Conflicts:
#	cocos2d/core/platform/CCClass.js
#	cocos2d/core/platform/attribute.js
@umbrellaPP umbrellaPP deleted the umbrellaPP:2.1.3_audio branch Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.