Add premultiply alpha processing to the render flow. #6451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
关联下 issue? 提到 2.4 吧？ |
jareguo
reviewed
Apr 1, 2020
| let color = null; | ||
| if (this.srcBlendFactor === cc.macro.BlendFactor.ONE) { | ||
| Color.premultiplyAlpha(_temp_color, this.node._color); | ||
| color = _temp_color._val; |
There was a problem hiding this comment.
这里会发生类型的转化，从非 int 转换成 int，可能会影响 jit 性能。建议 let color 初始化为整型
There was a problem hiding this comment.
这里会发生类型的转化，从非 int 转换成 int，可能会影响 jit 性能。建议 let color 初始化为整型
已修改
关联了论坛问题链接，可以提到2.4 |
2youyou2
approved these changes
Apr 26, 2020
holycanvas
approved these changes
May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
增加预乘alpha的处理
关联PR：cocos/engine-native#2343
论坛问题反馈：https://forum.cocos.org/t/bug-blend-one-one/83923/2