fix set font failed in native #7380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PPpro
reviewed
Sep 16, 2020
| done(err); | ||
| if (err && !task.isFinish) { | ||
| if (!cc.assetManager.force || firstTask) { | ||
| cc.error(err.message, err.stack); |
There was a problem hiding this comment.
还是打印下吧，上层经常会有用户不输出 err 信息，然后也没有办法知道是哪儿错了
| @@ -171,9 +170,8 @@ var utils = { | |||
| } | |||
| } | |||
| catch (e) { | |||
| err = e; | |||
| cc.error(e.message, e.stack); | |||
There was a problem hiding this comment.
不用，这里是查询依赖的地方，理论上是不会出错的，除非资源在网络传输过程中被第三方篡改了，如果出错了用户必须自己解决，force 也没用
PPpro
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: https://github.com/cocos-creator/2d-tasks/issues/3144
Changes: