Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset delegate value when cleanup scriptengine #15281

Merged
merged 1 commit into from Jun 2, 2023

Conversation

PatriceJiang
Copy link
Contributor

@PatriceJiang PatriceJiang commented Jun 1, 2023

When the ScriptEngine is cleaned up, all other se::Value instances should be reset as well, otherwise their state could stay invalid.

Notice:

Call onclose callback before reset _JSDelegate may be needed.

Changelog

  • bugfix: clear _JSDelegate object when scriptengine cleanup

Continuous Integration

This pull request:

  • needs automatic test cases check.

    Manual trigger with @cocos-robot run test cases afterward.

  • does not change any runtime related code or build configuration

    If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.


Compatibility Check

This pull request:

  • changes public API, and have ensured backward compatibility with deprecated features.
  • affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
  • affects file structure of the build package or build configuration which requires user project upgrade.
  • introduces breaking changes, please list all changes, affected features and the scope of violation.

@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Interface Check Report

This pull request does not change any public interfaces !

@PatriceJiang PatriceJiang marked this pull request as ready for review June 2, 2023 03:08
@PatriceJiang PatriceJiang requested a review from minggo June 2, 2023 03:08
@PatriceJiang PatriceJiang added this to the V3.8.0 milestone Jun 2, 2023
@minggo minggo merged commit 63fe38f into cocos:v3.8.0 Jun 2, 2023
23 checks passed
cocos-robot pushed a commit to cocos-robot/engine that referenced this pull request Jun 2, 2023
minggo pushed a commit that referenced this pull request Jun 2, 2023
…15294)

Co-authored-by: cocos-robot <cocos-robot@cocos.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants