Color val delete #17021
Merged
Color val delete #17021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interface Check Report! WARNING this pull request has changed these public interfaces:
@@ -3274,9 +3274,9 @@
* @zh
* 改变描边的颜色。
*/
get outlineColor(): math.Color;
- set outlineColor(value: math.Color);
+ set outlineColor(value: Readonly<math.Color>);
/**
* @en
* Change the outline width.
*
@@ -3298,9 +3298,9 @@
* @zh
* 阴影的颜色。
*/
get shadowColor(): math.Color;
- set shadowColor(value: math.Color);
+ set shadowColor(value: Readonly<math.Color>);
/**
* @en
* Offset between font and shadow.
*
@@ -12287,9 +12287,9 @@
/**
* @zh 全局雾颜色
* @en Global fog color
*/
- set fogColor(val: math.Color);
+ set fogColor(val: Readonly<math.Color>);
get fogColor(): math.Color;
/**
* @zh 当前雾化类型。
* @en The current global fog type.
@@ -17170,17 +17170,13 @@
set z(value: number);
get w(): number;
set w(value: number);
/**
- * @deprecated since v3.5.0, this is an engine private interface that will be removed in the future.
- */
- _val: number;
- /**
* @en Construct a same color from the given color
* @zh 构造与指定颜色相等的颜色。
* @param other Specified color
*/
- constructor(other: Color);
+ constructor(other: Readonly<Color>);
/**
* @en Construct a color form the hex color string
* @zh 用十六进制颜色字符串中构造颜色。
* @param hexString Hexadecimal color string.
@@ -17203,20 +17199,20 @@
/**
* @en Check whether the current color is identical with the given color
* @zh 判断当前颜色是否与指定颜色相等。
* @param other Specified color
- * @returns Returns `true` when all channels of both colours are equal; otherwise returns `false`.
+ * @returns Returns `true` when all channels of both colors are equal; otherwise returns `false`.
*/
- equals(other: Color): boolean;
+ equals(other: Readonly<Color>): boolean;
/**
* @en Calculate linear interpolation result between this color and another one with given ratio。
* @zh 根据指定的插值比率，从当前颜色到目标颜色之间做插值。
* @param to Target color
* @param ratio The interpolation coefficient.The range is [0,1].
*/
- lerp(to: Color, ratio: number): Color;
+ lerp(to: Readonly<Color>, ratio: number): Color;
/**
- * @en Convert to string with color informations
+ * @en Convert to string with color information.
* @zh 返回当前颜色的字符串表示。
* @returns A string representation of the current color.
*/
toString(): string;
@@ -17252,9 +17248,10 @@
/**
* @en convert Color to HEX color string.
* @zh 转换当前颜色为十六进制颜色字符串。
* @param fmt "#rrggbb" or "#rrggbbaa".
- * - `'#rrggbbaa'` obtains the hexadecimal value of the Red, Green, Blue, Alpha channels (**two**, high complement 0) and connects them sequentially.
+ * - `'#rrggbbaa'` obtains the hexadecimal value of the Red, Green, Blue,
+ * Alpha channels (**two**, high complement 0) and connects them sequentially.
* - `'#rrggbb'` is similar to `'#rrggbbaa'` but does not include the Alpha channel.
* @returns the Hex color string
* @example
* ```
@@ -17316,32 +17313,16 @@
* @param [b=0] blue component of the color
* @param [a=255] alpha component of the color
* @returns Current color.
*/
- set(other: Color): Color;
+ set(other: Readonly<Color>): Color;
set(r?: number, g?: number, b?: number, a?: number): Color;
/**
* @en Multiplies the current color by the specified color.
* @zh 将当前颜色乘以与指定颜色
* @param other The specified color.
*/
multiply(other: Color): Color;
- /**
- * @deprecated since v3.5.0, this is an engine private interface that will be removed in the future.
- */
- _set_r_unsafe(red: number): Color;
- /**
- * @deprecated since v3.5.0, this is an engine private interface that will be removed in the future.
- */
- _set_g_unsafe(green: number): Color;
- /**
- * @deprecated since v3.5.0, this is an engine private interface that will be removed in the future.
- */
- _set_b_unsafe(blue: number): Color;
- /**
- * @deprecated since v3.5.0, this is an engine private interface that will be removed in the future.
- */
- _set_a_unsafe(alpha: number): Color;
}
export function color(other: Color | string): Color;
export function color(r?: number, g?: number, b?: number, a?: number): Color;
/**
@@ -17526,9 +17507,8 @@
r: number;
g: number;
b: number;
a: number;
- _val: number;
}
export interface IMat3Like {
m00: number;
m01: number;
|
|
@minggo, Please check the result of
Task Details
|
|
@minggo, Please check the result of
Task Details
|
|
@minggo, Please check the result of
Task Details |
|
@minggo, Please check the result of
Task Details
|
6 tasks
dumganhar
reviewed
May 23, 2024
dumganhar
reviewed
May 23, 2024
dumganhar
reviewed
May 23, 2024
|
@minggo, Please check the result of
Task Details |
|
@minggo, Please check the result of
Task Details
|
dumganhar
approved these changes
May 24, 2024
|
@minggo ❗ There was an error during the execution of the tasks. Please check the logs for more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #13229
Changelog
Continuous Integration
This pull request:
Compatibility Check
This pull request: