385 adapter the taobaominigame ClearLRU procedure #17230

tangkaikk · 2024-06-26T09:29:02Z

Re: #

Changelog

Fixes #17040 : taobao Platform can not trigger clearLRU

Continuous Integration

This pull request:

needs automatic test cases check.

Manual trigger with @cocos-robot run test cases afterward.
does not change any runtime related code or build configuration

If any reviewer thinks the CI checks are needed, please uncheck this option, then close and reopen the issue.

Compatibility Check

This pull request:

changes public API, and have ensured backward compatibility with deprecated features.
affects platform compatibility, e.g. system version, browser version, platform sdk version, platform toolchain, language version, hardware compatibility etc.
affects file structure of the build package or build configuration which requires user project upgrade.
introduces breaking changes, please list all changes, affected features and the scope of violation.

1.taobao platform will clear tmp folder automatically. 2.when cachecount below 3, it will trigger LRU. 3.zip file, the path maybe is a zipfile.

github-actions · 2024-06-26T09:36:32Z

Interface Check Report

This pull request does not change any public interfaces !

zhefengzhang · 2024-06-26T09:58:31Z

platforms/minigame/common/engine/cache-manager.js

-            return;
+        let clearCachCount = Math.floor(caches.length / 3);
+        // 大于3则清理1/3， 小于等于3则全部清理
+        if(clearCachCount > 3){


You can use caches.length >= 12 instead of clearCacheCount > 3.

And below, you can use caches.length < 3 instead of clearCacheCount === 0.

This way, when caches.length < 3, you won't need to execute Math.floor(caches.length / 3).

可以使用 caches.length >= 12 代替 clearCacheCount > 3

下面可以使用 caches.length < 3 代替 clearCachCount === 0

这样可以使得当 caches.length < 3 时不用执行 Math.floor(caches.length / 3)

change to :
if(caches.length < 3){
console.warn("Due to caching large files in the game, there is insufficient storage space. Now starting forced cleaning.");
}
else{
caches.length = Math.floor(caches.length / 3);
}

…w 3 without div 3

bofeng-song · 2024-06-27T02:54:51Z

platforms/minigame/common/engine/cache-manager.js

-        if (caches.length === 0) {
-            cleaning = false;
-            return;
+        // 大于3则清理1/3， 小于等于3则全部清理


Please use english

have changed to English

zhefengzhang · 2024-07-02T02:40:10Z

platforms/minigame/common/engine/cache-manager.js

-            cleaning = false;
-            return;
+        // cache length above 3 then clear 1/3， or clear all caches
+        if(caches.length < 3){


Please maintain the same JavaScript formatting style as the original code, including leaving a space after if or else.

请保持与原代码一样的 js 排版格式，if 或 else 后面保留一个空格

The code has been formatted.

minggo · 2024-07-04T06:59:22Z

platforms/minigame/platforms/taobao-mini-game/wrapper/fs-utils.js

@@ -23,14 +23,14 @@
 THE SOFTWARE.
 ****************************************************************************/
 const fs = my.getFileSystemManager ? my.getFileSystemManager() : null;
-const outOfStorageRegExp = /the maximum size of the file storage/;  // not exactly right
+const outOfStorageRegExp = "10028";  // not exactly right


Why use string here?

taobao error code is "10028"

minggo · 2024-07-04T07:00:47Z

platforms/minigame/platforms/taobao-mini-game/wrapper/fs-utils.js

-    isOutOfStorage (errMsg) {
-        return outOfStorageRegExp.test(errMsg);
+    isOutOfStorage (errorCode) {
+        return errorCode.toString() == outOfStorageRegExp;


It is wired to compare string content to check out of storage.

taobao use errorCode "10028" to judge out of storage.

What's the type of errorCode?

normally it is string

If so, why need to change to string?

In case of the error code in the other apis like donwloadFile or copyFile which will trigger LRU in the feature, will be not string type.

as the type is not fixed, so it is better to do some logic to make it more cearly

please use === instead

i think outOfStorageRegExp is not accurate, may be outOfStorageErrorCode

I has changed the code as what you suggested.

… more cearly 1.use === instead 2.the param name change tooutOfStorageErrorCode

# Conflicts: # platforms/minigame/common/engine/cache-manager.js

This reverts commit bf4fcbe.

…17371) This reverts commit bf4fcbe.

tangkaikk added 3 commits June 26, 2024 16:13

385 adapter the taobaominigame ClearLRU procedure

1ed6bef

385 adapter the taobaominigame ClearLRU procedure

e2c4b41

385 adapter the taobaominigame ClearLRU procedure

32b4b26

1.taobao platform will clear tmp folder automatically. 2.when cachecount below 3, it will trigger LRU. 3.zip file, the path maybe is a zipfile.

zhefengzhang reviewed Jun 26, 2024

View reviewed changes

385 LRU, caches length equal or above 3 will div 3,caches length belo…

0c9e70e

…w 3 without div 3

bofeng-song reviewed Jun 27, 2024

View reviewed changes

tangkaikk added 3 commits July 2, 2024 10:16

Merge branch 'cocos:v3.8.5' into v3.8.5

5a1160a

change to english

2a6c651

Merge branch 'cocos:v3.8.5' into v3.8.5

bbef87e

zhefengzhang reviewed Jul 2, 2024

View reviewed changes

format js code

32b682f

bofeng-song approved these changes Jul 2, 2024

View reviewed changes

tangkaikk added 2 commits July 3, 2024 10:58

Merge branch 'cocos:v3.8.5' into v3.8.5

a535c9a

Merge branch 'cocos:v3.8.5' into v3.8.5

c8b040d

minggo reviewed Jul 4, 2024

View reviewed changes

tangkaikk added 2 commits July 4, 2024 16:15

Merge branch 'cocos:v3.8.5' into v3.8.5

ce014fc

as the type is not fixed, so it is better to do some logic to make it…

e64a33f

… more cearly 1.use === instead 2.the param name change tooutOfStorageErrorCode

minggo approved these changes Jul 4, 2024

View reviewed changes

Merge branch 'cocos:v3.8.5' into v3.8.5

253e869

zhefengzhang approved these changes Jul 9, 2024

View reviewed changes

Merge remote-tracking branch 'origin/v3.8.4' into v3.8.5

84afb4d

# Conflicts: # platforms/minigame/common/engine/cache-manager.js

minggo merged commit bf4fcbe into cocos:v3.8.4 Jul 16, 2024
10 checks passed

minggo added a commit that referenced this pull request Jul 16, 2024

Revert "384 adapter the taobaominigame ClearLRU procedure (#17230)"

64b7839

This reverts commit bf4fcbe.

minggo mentioned this pull request Jul 16, 2024

Revert "384 adapter the taobaominigame ClearLRU procedure " #17371

Merged

minggo added a commit that referenced this pull request Jul 16, 2024

Revert "384 adapter the taobaominigame ClearLRU procedure (#17230)" (#…

1cbc7bb

…17371) This reverts commit bf4fcbe.

tangkaikk mentioned this pull request Jul 16, 2024

385 adapter the taobaominigame ClearLRU procedure #17373

Open

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

385 adapter the taobaominigame ClearLRU procedure #17230

385 adapter the taobaominigame ClearLRU procedure #17230

tangkaikk commented Jun 26, 2024

github-actions bot commented Jun 26, 2024 •

edited

Loading

zhefengzhang Jun 26, 2024

tangkaikk Jun 26, 2024

bofeng-song Jun 27, 2024

tangkaikk Jul 2, 2024

zhefengzhang Jul 2, 2024

tangkaikk Jul 2, 2024

minggo Jul 4, 2024

tangkaikk Jul 4, 2024

minggo Jul 4, 2024

tangkaikk Jul 4, 2024 •

edited

Loading

minggo Jul 4, 2024

tangkaikk Jul 4, 2024 •

edited

Loading

minggo Jul 4, 2024

tangkaikk Jul 4, 2024

minggo Jul 4, 2024

tangkaikk Jul 4, 2024

385 adapter the taobaominigame ClearLRU procedure #17230

385 adapter the taobaominigame ClearLRU procedure #17230

Conversation

tangkaikk commented Jun 26, 2024

Changelog

Fixes #17040 : taobao Platform can not trigger clearLRU

Continuous Integration

Compatibility Check

github-actions bot commented Jun 26, 2024 • edited Loading

Interface Check Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tangkaikk Jul 4, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tangkaikk Jul 4, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Jun 26, 2024 •

edited

Loading

tangkaikk Jul 4, 2024 •

edited

Loading

tangkaikk Jul 4, 2024 •

edited

Loading