support compress texture #3039

2youyou2 · 2018-08-01T06:46:43Z

Re: cocos-creator/fireball#7906

Changelog:

support compress texture

2youyou2 · 2018-08-02T02:04:09Z

cocos2d/core/assets/CCTexture2D.js

        }
        let asset = "" + extId + "," + 
                    this._minFilter + "," + this._magFilter + "," + 
                    this._wrapS + "," + this._wrapT + "," + 
-                    (this._premultiplyAlpha ? 1 : 0);
+                    (this._premultiplyAlpha ? 1 : 0) + ',' + this.width + ',' + this.height;


压缩纹理后大小会被改变，需要记录之前 texture 的大小

jareguo · 2018-08-02T08:12:53Z

cocos2d/core/assets/CCTexture2D.js

@@ -285,6 +320,8 @@ var Texture2D = cc.Class({
        this.height = 0;

        this._texture = null;
+
+        this._compressed = false;


感觉有 _format 就行了，没必要专门存一个 _compressed

要方便判断的话，考虑封装一个静态方法，cc.Texture2D._isCompressed(texture) ?

jareguo · 2018-08-02T08:44:28Z

cocos2d/core/platform/CCMacro.js

+let SupportTextureFormats = ['.webp', '.jpg', '.jpeg', '.bmp', '.png'];
+if (cc.sys.isMobile) {
+    if (cc.sys.os === cc.sys.OS_IOS) {
+        SupportTextureFormats = ['.pvr'].join(SupportTextureFormats);


这个 join 是不是写错了？这样得到的值也只是 '.pvr'

jareguo · 2018-08-02T08:45:02Z

cocos2d/core/platform/CCMacro.js

+    // }
+}
+
+cc.macro.SupportTextureFormats = SupportTextureFormats;


要不要统一用 SUPPORT_TEXTURE_FORMATS

jareguo · 2018-08-02T08:47:40Z

cocos2d/core/renderer/render-engine.js

+      try {
+        var ext = gl.getExtension(vendorPrefixes[j] + name);
+        if (ext) {
+          this$1._extensions[name] = ext;


这里加一个 break; 会好点

jareguo · 2018-08-02T08:49:37Z

cocos2d/core/assets/CCTexture2D.js

@@ -687,7 +765,7 @@ var Texture2D = cc.Class({
                this.url = url;
            }
        }
-        if (fields.length === 6) {
+        if (fields.length === 8) {


感觉这个判断是多余的。如果这个判断有必要留着，那就应该兼容 .length === 6 和 8 两种情况

jareguo · 2018-08-02T08:51:32Z

cocos2d/core/assets/CCTexture2D.js

-                    extId = ext;
-                }
+            let natives = this._native;
+            if (!Array.isArray(natives)) {


这里拿的是 ext，不会是 arrary 吧？下面 this._setRawAsset(ext); 时，传入的也不是 array

jareguo · 2018-08-02T08:57:21Z

cocos2d/core/assets/CCTexture2D.js

+                let extFormat = extIds[i].split('@');
+                let tmpExt = extFormat[0];
+                tmpExt = tmpExt.charCodeAt(0) - CHAR_CODE_0;
+                tmpExt = Texture2D.extnames[tmpExt];


需要判断一下 tmpExt 拿不到的情况，例如 tmpExt = Texture2D.extnames[tmpExt] || extFormat;。如果后缀是其它类型（比如 gif？），就没办法从 extnames 数组里拿到。

jareguo · 2018-08-02T09:04:57Z

cocos2d/core/assets/CCTexture2D.js

+                let extId = "";
+                if (ext) {
+                    // ext@format
+                    let extFormat = ext.split('@');


这个 native 里面的 @，是在哪里生成的呢？

压缩纹理的时候生成的

dumganhar · 2018-08-03T07:12:34Z

cocos2d/core/load-pipeline/loader.js

@@ -119,6 +208,8 @@ var defaultMap = {
    'tiff' : loadImage,
    'webp' : loadImage,
    'image' : loadImage,
+    'pvr' : loadPVR,
+    'etc' : loadPVR,



etc怎么也用loadpvr？

https://github.com/toji/texture-tester/blob/master/js/webgl-texture-util.js#L457

web 上判断的逻辑是一样的

pandamicro · 2018-08-05T03:20:01Z

cocos2d/core/assets/CCTexture2D.js

+    RGB_PVRTC_2BPPV1: gfx.TEXTURE_FMT_RGB_PVRTC_2BPPV1,
+    /**
+     * rgba 2 bpp pvrtc
+     * @property RGB_PVRTC_2BPPV1


RGBA_PVRTC_2BPPV1

pandamicro · 2018-08-05T03:20:13Z

cocos2d/core/assets/CCTexture2D.js

+    RGBA_PVRTC_2BPPV1: gfx.TEXTURE_FMT_RGBA_PVRTC_2BPPV1,
+    /**
+     * rgb 4 bpp pvrtc
+     * @property RGB_PVRTC_2BPPV1


RGB_PVRTC_4BPPV1

pandamicro · 2018-08-05T03:20:24Z

cocos2d/core/assets/CCTexture2D.js

+    RGB_PVRTC_4BPPV1: gfx.TEXTURE_FMT_RGB_PVRTC_4BPPV1,
+    /**
+     * rgba 4 bpp pvrtc
+     * @property RGB_PVRTC_2BPPV1


RGBA_PVRTC_4BPPV1

pandamicro · 2018-08-05T03:21:10Z

cocos2d/core/assets/CCTexture2D.js

@@ -217,8 +246,13 @@ var Texture2D = cc.Class({
                // maybe returned to pool in webgl
                return this._image;
            },
-            set (image) {
-                this.initWithElement(image);
+            set (asset) {


不应该叫 asset 吧，这个对象不是 asset 类型，是一个 raw data 类型，直接用 data 吧

pandamicro · 2018-08-05T03:22:45Z

cocos2d/core/assets/CCTexture2D.js

@@ -285,6 +323,8 @@ var Texture2D = cc.Class({
        this.height = 0;

        this._texture = null;
+
+        this._exportedExts = null;


用 CC_EDITOR 限定一下吧

pandamicro · 2018-08-05T03:59:40Z

cocos2d/core/load-pipeline/loader.js

+
+// ETC1 format, from:
+// http://www.khronos.org/registry/webgl/extensions/WEBGL_compressed_texture_etc1/
+const COMPRESSED_RGB_ETC1_WEBGL = 0x8D64;


上面这几个加上 GL_ 前缀

pandamicro · 2018-08-05T04:00:53Z

cocos2d/core/load-pipeline/loader.js

+
+      case PVR_FORMAT_ETC1:
+        internalFormat = COMPRESSED_RGB_ETC1_WEBGL;
+        break;


这些 internalFormat 好像没有用啊？是不是只是用来判断支持格式的？如果是的话，不需要 internalFormat 参数吧？只要把 case 连起来，保证这些 case 不走 errorCallback 就好了把

pandamicro · 2018-08-05T04:02:03Z

cocos2d/core/platform/CCMacro.js

+    // }
+}
+
+cc.macro.SUPPORT_TEXTURE_FORMATS = SUPPORT_TEXTURE_FORMATS;


加一下 API 注释，说明目前的格式和平台支持情况

pandamicro · 2018-08-05T04:03:41Z

cocos2d/core/renderer/render-engine.js

-      var ext = gl.getExtension(name);
-      if (ext) {
-        this$1._extensions[name] = ext;
+    var vendorPrefixes = ["", "WEBKIT_", "MOZ_"];


哪些情况会出现这些前缀？目前格式还不统一？

pandamicro · 2018-08-05T04:03:43Z

cocos2d/core/renderer/render-engine.js

-      var ext = gl.getExtension(name);
-      if (ext) {
-        this$1._extensions[name] = ext;
+    var vendorPrefixes = ["", "WEBKIT_", "MOZ_"];


哪些情况会出现这些前缀？目前格式还不统一？

ios safari 是 WEBKIT_ 前缀，MOZ_ 还不知道，ios 的火狐？

https://github.com/toji/texture-tester/blob/master/js/webgl-texture-util.js#L337

2youyou2 added 3 commits August 1, 2018 14:45

support compress texture

15313a5

add cc.macro.SupportTextureFormats

c37b179

fixed texture test

1274229

2youyou2 commented Aug 2, 2018

View reviewed changes

update api comment

5aeaebf

jareguo suggested changes Aug 2, 2018

View reviewed changes

2youyou2 added 2 commits August 2, 2018 17:40

reverse texture size

bfbd36f

refine code

96258db

dumganhar reviewed Aug 3, 2018

View reviewed changes

jareguo approved these changes Aug 4, 2018

View reviewed changes

pandamicro suggested changes Aug 5, 2018

View reviewed changes

2youyou2 added 2 commits August 6, 2018 11:10

refine code

c5d0a3c

refine data

73c6f27

pandamicro approved these changes Aug 6, 2018

View reviewed changes

pandamicro merged commit 44d068b into cocos:next Aug 6, 2018

2youyou2 deleted the next-compress-texture branch September 20, 2018 03:42

ColinCollins mentioned this pull request Oct 29, 2018

fixed the richText signal content can't disappear problem #3440

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support compress texture #3039

support compress texture #3039

2youyou2 commented Aug 1, 2018

2youyou2 Aug 2, 2018

jareguo Aug 2, 2018

jareguo Aug 2, 2018

jareguo Aug 2, 2018

jareguo Aug 2, 2018

jareguo Aug 2, 2018

jareguo Aug 2, 2018

jareguo Aug 2, 2018

jareguo Aug 2, 2018

jareguo Aug 2, 2018

2youyou2 Aug 3, 2018

dumganhar Aug 3, 2018

2youyou2 Aug 3, 2018 •

edited

Loading

pandamicro Aug 5, 2018

pandamicro Aug 5, 2018

pandamicro Aug 5, 2018

pandamicro Aug 5, 2018

pandamicro Aug 5, 2018

pandamicro Aug 5, 2018

pandamicro Aug 5, 2018

pandamicro Aug 5, 2018

pandamicro Aug 5, 2018

pandamicro Aug 5, 2018

2youyou2 Aug 6, 2018

support compress texture #3039

support compress texture #3039

Conversation

2youyou2 commented Aug 1, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

2youyou2 Aug 3, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

2youyou2 Aug 3, 2018 •

edited

Loading