Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set audio volume and loop after _ensureDataLoaded #6935

Merged
merged 1 commit into from Jul 3, 2020
Merged

set audio volume and loop after _ensureDataLoaded #6935

merged 1 commit into from Jul 3, 2020

Conversation

PPpro
Copy link
Contributor

@PPpro PPpro commented Jun 28, 2020 •
edited

resolve https://github.com/cocos-creator/2d-tasks/issues/2930

changeLog:

  • 修复 AudioSource 组件勾选 loop 和 mute 无效的问题

对 audio 的操作，需要先确保 audio.src 存在

@PPpro PPpro requested a review from holycanvas June 28, 2020 06:55
@PPpro PPpro mentioned this pull request Jun 28, 2020
Closed
@PPpro PPpro merged commit b6b2c3f into cocos:v2.4.1 Jul 3, 2020
@PPpro PPpro deleted the 241_audio branch July 3, 2020 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holycanvas holycanvas holycanvas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@PPpro @holycanvas