Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed position synchronization problem between 3drigidbody and normal node #6949

Closed
wants to merge 1 commit into from
Closed

Fixed position synchronization problem between 3drigidbody and normal node #6949

wants to merge 1 commit into from

Conversation

zhefengzhang
Copy link
Contributor

No description provided.

@cocos-robot cocos-robot changed the base branch from v2.4.1 to v2.4.2-release July 6, 2020 04:07
Copy link
Contributor

@cocos-robot cocos-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We switched this PR to v2.4.2-release because v2.4.1 is about to be deleted.

@holycanvas holycanvas requested a review from JayceLai July 27, 2020 06:51
@@ -72,7 +72,7 @@ export class CannonWorld implements IPhysicsWorld {

// sync scene to physics
for (let i = 0; i < this.bodies.length; i++) {
this.bodies[i].syncSceneToPhysics();
this.bodies[i].syncSceneToPhysics(true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不能强制同步,需要判断 dirty 状态,否则会使休眠机制失效

现在的问题是什么?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

问题是如果一个父节点里,如果有一个 3D 刚体的子节点,那么父节点和非 3D 刚体的子节点将无法进行坐标变化。

@cocos-robot cocos-robot changed the base branch from v2.4.2-release to v2.4.3-release August 3, 2020 03:53
Copy link
Contributor

@cocos-robot cocos-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We switched this PR to v2.4.3-release because v2.4.2-release is about to be deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants