fix particle ia reuse #7267
Merged
fix particle ia reuse #7267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caryliu1999
reviewed
Sep 1, 2020
| ia.indexCount = this._indexCount * count; | ||
| this._iaInfo.drawInfos[0] = ia; | ||
| this._iaInfo.drawInfos[0].firstIndex = 0; | ||
| this._iaInfo.drawInfos[0].indexCount = this._indexCount * count; | ||
| this._iaInfoBuffer.update(this._iaInfo); |
There was a problem hiding this comment.
这个修改是改的什么问题？trailModel 也是同样的处理，看是否需要一起修改
There was a problem hiding this comment.
这个是由于 ia 是复用对象，从池中取出的，这里之前直接引用了对象，但这个对象不一定是它自己的 ia，所以会错误修改
caryliu1999
approved these changes
Sep 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: https://github.com/cocos-creator/3d-tasks/issues/4229