Fix morph issue on some platforms #7268

shrinktofit · 2020-09-01T11:39:41Z

Re: cocos-creator/3d-tasks#

Changelog:

Fix morph issue on platforms with shader >= 300 && having not float texture;
Fix GPU morph is failed when using rgba8 texture on some platforms.

…exture

shrinktofit · 2020-09-01T12:38:35Z

editor/assets/chunks/morph.chunk

-        int dataPixelStart = int(fetchVec3ArrayFromTexture(tex, iTarget).r);
+        // `+0.5` because in some platforms, the "fetched integer" may have small error.
+        // For example `26` may yeild `25.99999`, which is convert to `25` instead of `26` using `int()`.
+        int dataPixelStart = int(fetchVec3ArrayFromTexture(tex, iTarget).r + 0.5);


@YunHsiao Notable change

这种 offset 在 CPU 做是不是就行了，不要每个顶点都执行一遍了

Fixed at ac84a54

shrinktofit · 2020-09-01T12:38:57Z

editor/assets/chunks/morph.chunk

@@ -6,7 +6,7 @@
 #if __VERSION__ < 300
    in float a_vertexId;
    int getVertexId() {
-        return int(a_vertexId);
+        return int(a_vertexId + 0.5);


@YunHsiao Notable change

这个也一样

Fixed at ac84a54

shrinktofit added 3 commits September 1, 2020 19:38

Fix morph issue on platforms with shader >= 300 && having not float t…

4ba9a57

…exture

Fix

83d88f6

Update

77e44d4

shrinktofit commented Sep 1, 2020

View reviewed changes

Optimize

ac84a54

shrinktofit changed the title ~~Fix morph issue on platforms with shader >= 300 && having not float t…~~ Fix morph issue on some platforms Sep 2, 2020

YunHsiao approved these changes Sep 2, 2020

View reviewed changes

Typo

22e17e3

pandamicro merged commit 6803722 into cocos:3d-v1.2 Sep 2, 2020

shrinktofit deleted the FixMorph branch September 2, 2020 02:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix morph issue on some platforms #7268

Fix morph issue on some platforms #7268

shrinktofit commented Sep 1, 2020 •

edited

shrinktofit Sep 1, 2020

YunHsiao Sep 1, 2020

shrinktofit Sep 2, 2020

shrinktofit Sep 1, 2020

YunHsiao Sep 1, 2020

shrinktofit Sep 2, 2020

Fix morph issue on some platforms #7268

Fix morph issue on some platforms #7268

Conversation

shrinktofit commented Sep 1, 2020 • edited

shrinktofit Sep 1, 2020

Choose a reason for hiding this comment

YunHsiao Sep 1, 2020

Choose a reason for hiding this comment

shrinktofit Sep 2, 2020

Choose a reason for hiding this comment

shrinktofit Sep 1, 2020

Choose a reason for hiding this comment

YunHsiao Sep 1, 2020

Choose a reason for hiding this comment

shrinktofit Sep 2, 2020

Choose a reason for hiding this comment

shrinktofit commented Sep 1, 2020 •

edited