add update & updateList to Enum #7272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrinktofit
reviewed
Sep 2, 2020
cocos/core/value-types/enum.ts
Outdated
Comment on lines
96
to
114
| /** | ||
| * @param enumDef - the enum type defined from cc.Enum | ||
| * @return {Object[]} | ||
| */ | ||
| Enum.updateList = (enumDef) => { | ||
| const enums: any[] = enumDef.__enums__ || []; | ||
| enums.length = 0; | ||
| // tslint:disable-next-line: forin | ||
| for (const name in enumDef) { | ||
| const v = enumDef[name]; | ||
| if (Number.isInteger(v)) { | ||
| enums.push({ name, value: v }); | ||
| } | ||
| } | ||
| enums.sort((a, b) => a.value - b.value); | ||
| enumDef.__enums__ = enums; | ||
| return enums; | ||
| }; | ||
|
|
jareguo
reviewed
Sep 2, 2020
JayceLai
force-pushed
the
add_update_to_Enum
branch
from
aec8328
to
d997ebd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: cocos-creator/3d-tasks#4323
Changes: