fixed particle autoRemoveOnFinish bug #1888
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocos-robot
reviewed
Oct 21, 2019
There was a problem hiding this comment.
@Jno1995, v2.2.0-release branch will be deleted, so we edited the base branch to v2.2.1-release, or this PR will be killed by GitHub.
Please review the commits history to ensure that the PR does not polluted by unneeded commits from your origin branch.
If you need to merge to other branch, you can first click the Edit button on the right side of the PR title, then switch the base branch.
If necessary, welcome to resubmit a new PR. Thanks!
|
这个 PR 关闭，以新的 PR: #1905 ,为准。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cocos-creator/2d-tasks#1919
未修复之前，当 particle 组件的节点为勾选 autoRemoveOnFinish 时，如果它没有选择 playOnLoad 的话，就会在 _finishedSimulation 函数中被销毁。
加了一个 readyPlay 字段，记录粒子是否处理准备播放阶段。