Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why Cocos2d-x #68

Closed
onobori opened this issue Nov 28, 2017 · 11 comments
Closed

Why Cocos2d-x #68

onobori opened this issue Nov 28, 2017 · 11 comments

Comments

@onobori
Copy link

onobori commented Nov 28, 2017

URL : https://github.com/cocos2d/cocos2d-x-docs/blob/master/en/about/why.md

Viewing the bottom of this page from smartphone, the "Feedback" button is put on the "next" (>) button. That makes to touch the next button difficult.

@onobori onobori closed this as completed Nov 28, 2017
@onobori onobori reopened this Nov 28, 2017
@onobori
Copy link
Author

onobori commented Nov 28, 2017

Sorry, I wrote a wrong URL. This issue happens on below.

http://cocos2d-x.org/docs/en/about/getting_started.html

@slackmoehrle
Copy link
Collaborator

I'll check it out, I am not sure just how much support we will provide from a phone as most developers would view these docs on a computer or some sort. Let me talk it over with the docs team and see. Thank you for reporting this.

@Priority10
Copy link

Well, some of us learn when we are on the go. :)
I confirm, this happens on many pages, in fact depends on the screen resolution of the device.
The Feedback button should not be floating, this will solve the problem.

@onobori
Copy link
Author

onobori commented Nov 29, 2017

Think you for responding!

@slackmoehrle Same issue happens on the PC
browser with a small monitor. Actually, I confirm that a half-width browser has this issue. My laptop's monitor is 12.5 inch.

@Priority10 Great! I'm glad to hear that.

@slackmoehrle
Copy link
Collaborator

Can you post a few screenshots, please?

@Priority10
Copy link

iPhone 6
iphone6

Nexus 6P
nexus 6p

540x960
540x960

@onobori
Copy link
Author

onobori commented Dec 2, 2017

Sorry for a late reply.

Xperia Z5
screenshot_20171128-183018

683x768
pc_firefox

@drelaptop
Copy link
Contributor

maybe we can realize "Feedback" by footer, I find some footer plugins, that will make some help.

@slackmoehrle
Copy link
Collaborator

Cool, thanks for looking. Lets have a try with these locally. I can help.

This was referenced Dec 18, 2017
@drelaptop
Copy link
Contributor

make feedback button responsive, the logic is:

  if (document.body.offsetHeight * 9 >= document.body.offsetWidth * 12) {
     not show feedback button;
  }else{
     show feedback button;
  }

docs on cocos2d-x.org have fixed this @onobori

@Priority10
Copy link

Nice. Thanks @drelaptop !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants