Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.17 external update request, include solve Lua issues #19116

Open
drelaptop opened this issue Oct 15, 2018 · 15 comments
Open

3.17 external update request, include solve Lua issues #19116

drelaptop opened this issue Oct 15, 2018 · 15 comments

Comments

@drelaptop
Copy link
Contributor

  • cocos2d-x version:3.17
  • devices test on: request by forum
  1. NDK 18 stable have been published, consider to update android external built tool to NDK 18
  2. Lua crash when use 3.17, but not older versions, possible external issues

thread

Lua issues,

@drelaptop
Copy link
Contributor Author

I have doubt on this commit cocos2d/cocos2d-x-3rd-party-libs-src@c7ce4f6

when compile luajit, why use gcc directly, is it a cross-compiler ? change it to compiler same with others will trigger what errors.

could you research this when you free. @PatriceJiang

@PatriceJiang
Copy link
Contributor

👌, pls assign this issue to me

@drelaptop
Copy link
Contributor Author

more Lua release crash feedback in Chinese forum

https://forum.cocos.com/t/cocos2d-x-3-1-7-release/68421

@PatriceJiang PatriceJiang modified the milestones: next, 3.17.1 Nov 14, 2018
@drelaptop
Copy link
Contributor Author

so I think lua external libs issues should been solved before 3.17.1 released. but all 3.17 external update we can put it into next release. @PatriceJiang @crazyhappygame

@drelaptop
Copy link
Contributor Author

can't reproduce lua issue by run lua-tests release, move it into next milestone

@drelaptop drelaptop modified the milestones: 3.17.1, next Nov 16, 2018
@semgilo
Copy link

semgilo commented Mar 7, 2019

how about the issue now?@drelaptop @PatriceJiang

@minggo
Copy link
Contributor

minggo commented Mar 8, 2019

i think lua crash issue is fixed in 3.17.1

@semgilo
Copy link

semgilo commented Mar 8, 2019

@minggo thx, i will take a test.

@semgilo
Copy link

semgilo commented Mar 9, 2019

@minggo i upgraded to 3.17.1 and got other issues.
win32: crash on close window and some performance issues
There may be some parts that have not been upgraded sucessfully. I don't have much time to debug . Is there any way to upgrade only part of it?

@minggo
Copy link
Contributor

minggo commented Mar 11, 2019

Yep, you can just replace the luajit lib.

@semgilo
Copy link

semgilo commented Mar 11, 2019

I replace the luajit and crash again,release mode debug is ok

@minggo
Copy link
Contributor

minggo commented Mar 11, 2019

Does it crash in luajit. And did you clean and rebuild the application?

@semgilo
Copy link

semgilo commented Mar 12, 2019

It works, but you need to pay attention to the changes in luajit
math.mod -> math.fmod
string.gfind -> string.gmatch
LuaJIT/LuaJIT#302

@minggo
Copy link
Contributor

minggo commented Mar 12, 2019

Thanks for the information. How did you find it?

@semgilo
Copy link

semgilo commented Mar 12, 2019

i replace luajit lib, it crashes for math.mod is nil. i fixed it by google and test on many devices. everything is ok.

@minggo minggo modified the milestones: 3.17.2, next Apr 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants