You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
First issue, there are no comments to indicate what the differences are between each of the ALOGV, ALOGD, ALOGI, ALOGW, ALOGE macros, or what their specific purpose is.
Second issue, they should be moved out of the audio code and into another more suitable file, since they aren't audio specific, but rather useful when working with threads. There are even comments in those files indicating that they need to be moved, such as:
AudioEngine-win32.cpp:
//FIXME: Move _winLog, winLog to a separated file
and
AudioMacros.h
//FIXME:Move the definition of the following macros to a separated file.
The text was updated successfully, but these errors were encountered:
AudioEngine-win32.cpp and AudioMacros.h have references to the following logging macros and methods that are threadsafe:
ALOGV, ALOGD, ALOGI, ALOGW, ALOGE
static void _winLog(const char *format, va_list args)
void audioLog(const char * format, ...)
First issue, there are no comments to indicate what the differences are between each of the ALOGV, ALOGD, ALOGI, ALOGW, ALOGE macros, or what their specific purpose is.
Second issue, they should be moved out of the audio code and into another more suitable file, since they aren't audio specific, but rather useful when working with threads. There are even comments in those files indicating that they need to be moved, such as:
AudioEngine-win32.cpp:
//FIXME: Move _winLog, winLog to a separated file
and
AudioMacros.h
//FIXME:Move the definition of the following macros to a separated file.
The text was updated successfully, but these errors were encountered: