Fix AXI signals #52
Closed
Fix AXI signals #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delafthi
force-pushed
the
fix/axi_signals
branch
from
a11c99b
to
d982560
Compare
|
Added missing |
|
@alexforencich Would it be possible for you to have a look on this? |
|
I don't think the changes are really necessary. cocotbext-axi works for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_signals/_optional_signalsdefinitions inamba.pydoesn't seem to conform with the specification. This PR corrects the_signalsand_optional_signalsdefinition according to the AMBA AXI and ACE Protocol Specification chapter A9.3.Additionally, I added missing type annotations.
All
test_axi4tests fail for me. However, they also fail for me without the changes and are probably due to #33. Though, the exampletest_axi_lite_slavepasses.