New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thoughts on adding git rev to dev version numbers? #3562
Comments
In case it's not clear, the motivation for this would be to be able to determine what exact version of cocotb one is running when using non-released versions. |
setuptools-scm did this. But it did a lot more than that, poorly. Maybe you can extract the logic it uses from it. Technically I think the correct version we should be using is And ofc, this should be totally optional so people can still install release versions from source without needing more dependencies. |
I would like this as well. |
I should have known there was a PEP, there's always a PEP. It's PEP 440, but that says it's historical and points to this: Apparently Also this:
If I'm reading this correctly Also:
So is it fine to always add the git rev when there is a |
How would everyone feel about adding
git rev-parse --short HEAD
to__version__
? Currently it is2.0.0.dev0
and I'm not sure what the final0
is for, but I'm guessing it's to manually increment as one feels like? What if instead it were2.0.0.dev-d379318e
? I'd propose that we build the file on the fly insetup.py
but only add the git rev when the non-suffixed version (stored as a variable insetup.py
) includesdev
.I can take a stab at this if people are onboard.
The text was updated successfully, but these errors were encountered: