Fix libraries runpath on newer Debian

[themperek]

Due to changes in Debian (default --enable-new-dtagshas), rpath has to be set on dependent libraries.
See: https://stackoverflow.com/questions/52018092/how-to-set-rpath-and-runpath-with-gcc-ld

[eric-wieser]

I'm not sure I understand why RUNPATH isn't working for our use-case. Are you able to work that out?

[eric-wieser]

Supposedly

The new-style DT_RUNPATH is not extended recursively when resolving transitive dependencies, as was the case with RPATH. That is, if we dlopen() libA.so, which in turn marks libB.so as DT_NEEDED, which in turn requires a libC.so — then the resolution for libC.so will visit only the RUNPATH given in libB.so, but not the RUNPATH given in libA.so (to the contrary, the old RPATH used to visit all these locations).
This behaviour was chosen deliberately, in compliance with the ELF spec, as can be seen in this glibc bug #13945 and the developer comment by Roland McGrath from 2002 mentioned therein.

Based on this, maybe we just need to set runpath on one more library.

Can you paste the original failure message without this change?

[themperek]

If I set -rpath,$ORIGIN on all depend libraries it seems to work with RUNPATH. I will try to update today.

[eric-wieser]

That might be the more appropriate fix.

[themperek]

It seems to work. Test on Ubuntu and Windows WLS1.

[eric-wieser]

Thanks! Commit message needs updating when squashing.

[themperek]

What is wrong with the message?

[eric-wieser]

Nevermind, misread it