Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup TestError #2177

Merged
merged 8 commits into from Nov 8, 2020
Merged

Cleanup TestError #2177

merged 8 commits into from Nov 8, 2020

Commits on Nov 5, 2020

  1. Use a more appropriate exception when a GPI object cannot be mapped t… 

    …o a Python type

`TestError` was unnecessary here. It was used to fail the test if a signal could not be mapped to a Python SimHandle type. This could be easily done with a standard exception. This cleans up the last usage of `TestError` in core code and will allow for it's deprecation.
    @ktbarrett
    ktbarrett committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    31a4dc0 View commit details
    Browse the repository at this point in the history

  2. Deprecate TestError 

    TestError is no longer used internally, and it was never a good idea for a user to raise a TestError rather than a TestFailure, so it is being deprecated.
    @ktbarrett
    ktbarrett committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    690519b View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review

    @ktbarrett
    ktbarrett committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    c6dda8a View commit details
    Browse the repository at this point in the history

  4. Allow more than one warning to be collected in assert_deprecated 

    `assert_raises` causes 2 warnings. One for calling into the deprecated `assert_raises` and another for instantiating the deprecated `TestError`.
    @ktbarrett
    ktbarrett committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    35d2b2e View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
    @ktbarrett @eric-wieser
    ktbarrett and eric-wieser committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    021ac99 View commit details
    Browse the repository at this point in the history

  6. Update cocotb/result.py 

    Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
    @ktbarrett @eric-wieser
    ktbarrett and eric-wieser committed Nov 5, 2020
    Configuration menu
    Copy the full SHA
    96e3337 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2020

  1. Apply suggestions from code review 

    Co-authored-by: Marlon James <marlon.james@garmin.com>
    @ktbarrett
    ktbarrett and Marlon James committed Nov 6, 2020
    Configuration menu
    Copy the full SHA
    8f6ed0c View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2020

  1. Add newsfragement

    @ktbarrett
    ktbarrett committed Nov 8, 2020
    Configuration menu
    Copy the full SHA
    dd9a7d5 View commit details
    Browse the repository at this point in the history