Make scheduler interfaces private #2331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktbarrett
added
the
type:cleanup
ktbarrett
force-pushed
the
cleanup-private-public
branch
from
a54a7ee
to
25b368c
Compare
Codecov Report
@@ Coverage Diff @@
## master #2331 +/- ##
==========================================
- Coverage 65.88% 61.02% -4.86%
==========================================
Files 51 50 -1
Lines 8122 8167 +45
Branches 1364 1367 +3
==========================================
- Hits 5351 4984 -367
- Misses 2177 2633 +456
+ Partials 594 550 -44
Continue to review full report at Codecov.
|
marlonjames
reviewed
Jan 8, 2021
ktbarrett
force-pushed
the
cleanup-private-public
branch
from
25b368c
to
4a0437b
Compare
ktbarrett
force-pushed
the
cleanup-private-public
branch
from
4a0437b
to
e3b7390
Compare
|
Should I create a newsfragment for #2278? I don't think I should list every change because in the end there may be a lot. |
|
I think a summary newsfragment would be good. We can link to the individual PRs from that issue if we want to track all of the changes. |
ktbarrett
force-pushed
the
cleanup-private-public
branch
from
04ff212
to
b93c76f
Compare
marlonjames
approved these changes
Jan 9, 2021
cmarqu
reviewed
Jan 9, 2021
Co-authored-by: Colin Marquardt <cmarqu42@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the scheduler methods which are currently "public" (don't start with an underscore) are not safe or reasonable for a user to call under any circumstance and were definitely intended to be private. Stubs remain in place of the original name to throw deprecation warnings. The interfaces not privatized are:
add, same thing ascocotb.fork.create_task, is a staticmethod so it is safe to call whenever.start_soon, designed to be user facing.It is intended that the stubs will be removed in 2.0.
xref #2278.