Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Range and Array modeling types #2510

Merged
merged 54 commits into from Jun 22, 2021
Merged

Add Range and Array modeling types #2510

merged 54 commits into from Jun 22, 2021

Commits on Jun 9, 2021

  1. Add Range modeling type 

    Range datatype mimic's Python "range" type, but with inclusive right
bounds like is seen in HDLs.
    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    8d7e270 View commit details
    Browse the repository at this point in the history

  2. Add Array modeling type

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    12d6d10 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Colin Marquardt <cmarqu42@gmail.com>
    @ktbarrett @cmarqu
    ktbarrett and cmarqu committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    efa2878 View commit details
    Browse the repository at this point in the history

  4. Use compat layer for cache and cached_property

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    b5fa0ef View commit details
    Browse the repository at this point in the history

  5. Run black

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    63499fb View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Co-authored-by: Colin Marquardt <cmarqu42@gmail.com>
    @ktbarrett @cmarqu
    ktbarrett and cmarqu committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    dbad6f3 View commit details
    Browse the repository at this point in the history

  7. Remove 'you' from docstrings

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    0b73489 View commit details
    Browse the repository at this point in the history

  8. Run pyupgrade --py36-plus

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    d36384e View commit details
    Browse the repository at this point in the history

  9. fix compat

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    f3b1fa1 View commit details
    Browse the repository at this point in the history

  10. Apply suggestions from code review 

    Co-authored-by: Colin Marquardt <cmarqu42@gmail.com>
    @ktbarrett @cmarqu
    ktbarrett and cmarqu committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    0589aec View commit details
    Browse the repository at this point in the history

  11. Fix compat again...

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    9a760f3 View commit details
    Browse the repository at this point in the history

  12. Add doctests

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    fd7a156 View commit details
    Browse the repository at this point in the history

  13. Improve indexing exception

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    2cc0962 View commit details
    Browse the repository at this point in the history

  14. More detail in exceptions

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    e2fe857 View commit details
    Browse the repository at this point in the history

  15. Improve constructor

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    0997d15 View commit details
    Browse the repository at this point in the history

  16. encapsulate construction of value and range for subclasses

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    65fc6c7 View commit details
    Browse the repository at this point in the history

  17. Apply suggestions from code review 

    Co-authored-by: Colin Marquardt <cmarqu42@gmail.com>
    @ktbarrett @cmarqu
    ktbarrett and cmarqu committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    8bce09f View commit details
    Browse the repository at this point in the history

  18. Condense notes

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    9d11638 View commit details
    Browse the repository at this point in the history

  19. don't use cached_property anymore

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    30daf82 View commit details
    Browse the repository at this point in the history

  20. Improve equality

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    9c4d5f4 View commit details
    Browse the repository at this point in the history

  21. Update cocotb/types/range.py 

    Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
    @ktbarrett @eric-wieser
    ktbarrett and eric-wieser committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    cdaa1e4 View commit details
    Browse the repository at this point in the history

  22. Improve error message

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    3e65b53 View commit details
    Browse the repository at this point in the history

  23. inline unnecessarily split function

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    3066717 View commit details
    Browse the repository at this point in the history

  24. Fix a bug

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    c6bb59e View commit details
    Browse the repository at this point in the history

  25. Explicitly state that right bound is inclusive

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    bdd3662 View commit details
    Browse the repository at this point in the history

  26. Improve method documentation

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    97d01b9 View commit details
    Browse the repository at this point in the history

  27. Apply suggestions from code review 

    Co-authored-by: Colin Marquardt <cmarqu42@gmail.com>
    @ktbarrett @cmarqu
    ktbarrett and cmarqu committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    7003f7a View commit details
    Browse the repository at this point in the history

  28. Removed unused definition

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    884dd18 View commit details
    Browse the repository at this point in the history

  29. Improve equality behavior

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    2e78377 View commit details
    Browse the repository at this point in the history

  30. Improve documentation on equality and other operations

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    4e1ed9e View commit details
    Browse the repository at this point in the history

  31. Use double quotes in docstrings like black

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    3d20929 View commit details
    Browse the repository at this point in the history

  32. Improve warnings on differences with builtin sequence types

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    0ba13c7 View commit details
    Browse the repository at this point in the history

  33. Simplify array element construction

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    dd7144f View commit details
    Browse the repository at this point in the history

  34. Update cocotb/types/array.py

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    40dd0f7 View commit details
    Browse the repository at this point in the history

  35. 100% coverage baby...

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    a8afdf1 View commit details
    Browse the repository at this point in the history

  36. Apply suggestions from code review

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    a35186f View commit details
    Browse the repository at this point in the history

  37. Update cocotb/types/range.py 

    Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
    @ktbarrett @eric-wieser
    ktbarrett and eric-wieser committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    baea8ec View commit details
    Browse the repository at this point in the history

  38. Remove .length

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    a5c682b View commit details
    Browse the repository at this point in the history

  39. Move 'concat' to base array

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    3874f09 View commit details
    Browse the repository at this point in the history

  40. Apply suggestions from code review

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    c313ad0 View commit details
    Browse the repository at this point in the history

  41. Allow user to change bounds after array creation

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    8686fcf View commit details
    Browse the repository at this point in the history

  42. mypy fixes

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    1bb5b1e View commit details
    Browse the repository at this point in the history

  43. Additional black fixes

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    53cb1ee View commit details
    Browse the repository at this point in the history

  44. Further take Eric's advice and simplify the array code more

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    5310be9 View commit details
    Browse the repository at this point in the history

  45. Fix mypy fixes

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    8d3773c View commit details
    Browse the repository at this point in the history

  46. Make concat a free binary operation

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    579dd02 View commit details
    Browse the repository at this point in the history

  47. Apply suggestions from code review

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    fdcdfbe View commit details
    Browse the repository at this point in the history

  48. Improve concat implementation

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    ee880d2 View commit details
    Browse the repository at this point in the history

  49. Fixes for special method resolution

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    e1e30a1 View commit details
    Browse the repository at this point in the history

  50. Fix __concat__=None problem

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    ea0ef7d View commit details
    Browse the repository at this point in the history

  51. Fix occurences of __class__

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    f979a65 View commit details
    Browse the repository at this point in the history

  52. Final black run

    @ktbarrett
    ktbarrett committed Jun 9, 2021
    Configuration menu
    Copy the full SHA
    73652e8 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2021

  1. Add note about constructing ranges

    @ktbarrett
    ktbarrett committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    20e4257 View commit details
    Browse the repository at this point in the history

  2. Add concat() to reference documentation

    @ktbarrett
    ktbarrett committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    7a18d2c View commit details
    Browse the repository at this point in the history