Remove Bit class #3549
Merged
Remove Bit class #3549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3549 +/- ##
===========================================
+ Coverage 47.56% 66.63% +19.07%
===========================================
Files 48 48
Lines 8383 8480 +97
Branches 2387 2414 +27
===========================================
+ Hits 3987 5651 +1664
+ Misses 3794 1696 -2098
- Partials 602 1133 +531 ☔ View full report in Codecov by Sentry. |
ktbarrett
force-pushed
the
remove-bit
branch
2 times, most recently
from
5b825f4
to
77cbe83
Compare
Previously Bit was supposed to be a part of a grander plan to incorporate more HDL types, but that plan was abandoned and Bit is now useless. Additionally, Logic was expanded to cover the whole 9-value VHDL std_logic type because SV's 4-value type is a strict subset and why not have more features than less?
cmarqu
approved these changes
Dec 7, 2023
|
I will look at this tonight. |
marlonjames
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously Bit was supposed to be a part of a grander plan to incorporate more HDL types, but that plan was abandoned and Bit is now useless.
Additionally, Logic was expanded to cover the whole 9-value VHDL std_logic type because SV's 4-value type is a strict subset and why not have more features than less?
Closes #2666.