Make scheduler private #3806
Merged
Make scheduler private #3806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktbarrett
force-pushed
the
scheduler-private
branch
from
8ae2a8c
to
dad28dd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3806 +/- ##
=======================================
Coverage 73.53% 73.53%
=======================================
Files 49 49
Lines 7915 7915
Branches 2207 2204 -3
=======================================
Hits 5820 5820
+ Misses 1596 1586 -10
- Partials 499 509 +10 ☔ View full report in Codecov by Sentry. |
marlonjames
added
type:cleanup
marlonjames
approved these changes
Mar 25, 2024
cmarqu
approved these changes
Mar 25, 2024
ktbarrett
force-pushed
the
scheduler-private
branch
from
dad28dd
to
e0d94b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3805.
cocotb.scheduler.Scheduleris not yet an independently usable object, nor has any use being touched by users during normal operation, so it has no use in being public API.