Introduce mode to trust inertial writes #3875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3875 +/- ##
==========================================
- Coverage 72.65% 72.63% -0.03%
==========================================
Files 49 50 +1
Lines 8055 8060 +5
Branches 2221 2208 -13
==========================================
+ Hits 5852 5854 +2
+ Misses 1699 1681 -18
- Partials 504 525 +21 ☔ View full report in Codecov by Sentry. |
ktbarrett
force-pushed
the
read-write-stuff
branch
4 times, most recently
from
46c7ae9
to
a2f2a35
Compare
|
ktbarrett
commented
May 2, 2024
ktbarrett
force-pushed
the
read-write-stuff
branch
3 times, most recently
from
1862ddc
to
ed0d29c
Compare
ktbarrett
commented
May 7, 2024
ktbarrett
force-pushed
the
read-write-stuff
branch
3 times, most recently
from
a3d8379
to
e737666
Compare
|
Giving up on Riviera's VHPI. Their scheduler has some serious issues. |
|
cmarqu
reviewed
May 8, 2024
ktbarrett
force-pushed
the
read-write-stuff
branch
2 times, most recently
from
46905ad
to
b309b8e
Compare
|
|
cmarqu
reviewed
May 12, 2024
|
Waiting on #3895. |
ktbarrett
force-pushed
the
read-write-stuff
branch
from
41ee6f1
to
fc5f3e6
Compare
|
Unblocked. |
ktbarrett
force-pushed
the
read-write-stuff
branch
from
fc5f3e6
to
a67fd52
Compare
cmarqu
reviewed
Jun 7, 2024
Behavior and performance optimization by trusting inertial writes in the VPI/VHPI/FLI rather than mimicing that behavior by applying writes in the ReadWrite callback. Add a couple tests for write scheduling behavior.
ktbarrett
force-pushed
the
read-write-stuff
branch
from
a67fd52
to
6f3373f
Compare
cmarqu
approved these changes
Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3544.
Just read the documentation. This provides better behavior and performance where it will work.
TODO