Support newer Verilator in backwards compatible way

[ktbarrett]

xref #3896.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 64.77%. Comparing base (8acffb4) to head (5e1ba3e).

Files	Patch %	Lines
cocotb/share/lib/vpi/VpiCbHdl.cpp	0.00%	1 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff               @@
##           stable/1.9    #3897      +/-   ##
==============================================
- Coverage       64.79%   64.77%   -0.02%     
==============================================
  Files              49       49              
  Lines            9131     9133       +2     
  Branches         2461     2459       -2     
==============================================
  Hits             5916     5916              
+ Misses           2627     2623       -4     
- Partials          588      594       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ktbarrett]

Strange it isn't covering the new line, cocotb_build_libs.py says the define is VERILATOR?

[marlonjames]

Verilator CI isn't being run. You can see it's missing from the output of the generate script.

The Verilator CI changes weren't backported yet.

[ktbarrett]

@marlonjames Do we trust to merge this as is, or should we wait until Verilator CI changes are backported?

[marlonjames]

I'm okay with this, assuming we don't want to wait and bump the minimum Verilator version for 1.9.