Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch_wb_content "js_" flag replaced w/ "id_" #2

Merged
merged 1 commit into from
Apr 23, 2018

Conversation

marshallduval
Copy link
Contributor

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 32

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 93.023%

Totals Coverage Status
Change from base Build 29: 0.2%
Covered Lines: 400
Relevant Lines: 430

💛 - Coveralls

4 similar comments
@coveralls
Copy link

Pull Request Test Coverage Report for Build 32

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 93.023%

Totals Coverage Status
Change from base Build 29: 0.2%
Covered Lines: 400
Relevant Lines: 430

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 32

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 93.023%

Totals Coverage Status
Change from base Build 29: 0.2%
Covered Lines: 400
Relevant Lines: 430

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 32

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 93.023%

Totals Coverage Status
Change from base Build 29: 0.2%
Covered Lines: 400
Relevant Lines: 430

💛 - Coveralls

@coveralls
Copy link

coveralls commented Apr 11, 2018

Pull Request Test Coverage Report for Build 32

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 93.023%

Totals Coverage Status
Change from base Build 29: 0.2%
Covered Lines: 400
Relevant Lines: 430

💛 - Coveralls

@wumpus
Copy link
Member

wumpus commented Apr 12, 2018

What's the rationale for this change? I was thinking that the Wayback didn't modify .js files when I wrote this code, but on second thought I recall that it does try to transform urls it sees in .js. I only fetch .html from it so I had not noticed.

@wumpus wumpus closed this Apr 23, 2018
@wumpus wumpus reopened this Apr 23, 2018
@wumpus wumpus merged commit 8eab187 into cocrawler:master Apr 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants