Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compatibility with Silex 2 #120

Closed
shamotj opened this issue Jul 4, 2016 · 1 comment
Closed

compatibility with Silex 2 #120

shamotj opened this issue Jul 4, 2016 · 1 comment

Comments

@shamotj
Copy link
Contributor

shamotj commented Jul 4, 2016

Current version is not compatible with Silex version 2. ServiceProviderInterface is no longer part of Silex 2. It is replaced with Pimple\ServiceProviderInterface. Only minor changes are needed to make it work. Question is, what about backward compatibility? Will new version support only Silex ^2.0 or earlier versions as well?
shamotj pushed a commit to shamotj/slugify that referenced this issue Jul 4, 2016
Fix compatibility with Silex 2 - issue cocur#120
008e081
florianeckerstorfer pushed a commit that referenced this issue Jul 5, 2016
@shamotj
Fix compatibility with Silex 2 - issue #120 (#121)
1888c3c
@florianeckerstorfer
Copy link
Member

Fixed by #121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@florianeckerstorfer @shamotj