Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

French is missing in DefaultRuleProvider #165

Closed
coders-market opened this issue Mar 29, 2017 · 1 comment
Closed

French is missing in DefaultRuleProvider #165

coders-market opened this issue Mar 29, 2017 · 1 comment

Comments

@coders-market
Copy link

Hi,

the French.json is available, but it isn't included in the DefaultRuleProvider. I run locally the generate-default.php and french was then added as well.

So this should be easy to fix.

Thank you!

gsouf added a commit to gsouf/slugify that referenced this issue Apr 10, 2017
@gsouf
Copy link
Contributor

gsouf commented Apr 10, 2017

As easy as this:

git clone https://github.com/gsouf/slugify
cd slugify/
php bin/generate-default.php
git add .
git commit -m 'include french rules in DefaultReuleProvider fix #165'
git push

Took me about 3 minutes, including the time to open the PR...

Is this repository maintained?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant