Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Slovak rules #230

Merged
merged 3 commits into from Nov 26, 2019
Merged

Add Slovak rules #230

merged 3 commits into from Nov 26, 2019

Conversation

@bartko-s
Copy link
Contributor

@bartko-s bartko-s commented Jul 11, 2019

No description provided.

@florianeckerstorfer
Copy link
Member

@florianeckerstorfer florianeckerstorfer commented Nov 26, 2019

First of all, I am really sorry for the late reply.

Could you add some tests to see if the Slovak rules are working (this is especially important to keep them working when we merge additional PRs. And please update with the latest changes from master so that we can see if the tests pass?

Loading

"ú": "u",
"ý": "y",
"ž": "z"
}
Copy link
Contributor

@OskarStark OskarStark Nov 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add a newline

Loading

Copy link
Contributor Author

@bartko-s bartko-s Nov 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline added

Loading

@bartko-s
Copy link
Contributor Author

@bartko-s bartko-s commented Nov 26, 2019

PR updaded from latest origin/master and test added

Loading

@florianeckerstorfer
Copy link
Member

@florianeckerstorfer florianeckerstorfer commented Nov 26, 2019

@bartko-s Thanks, 👍

Loading

@florianeckerstorfer florianeckerstorfer merged commit ed496e9 into cocur:master Nov 26, 2019
3 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants