Feature/regexp

[acelaya]

This allows the user to define the regular expression to be used to sanitize the slug.
It can be set either in the constructor or by calling the method setRegExp.
By default the regular expression is the same that was being used until now.

[florianeckerstorfer]

Why is the constant named LOWERCASE_NUMBERS_UNDERSCORES? Also, in which way does the name relate to the expression?

[acelaya]

Whoops, I meant to name it LOWERCASE_NUMBERS_DASHES (not UNDERSCORES) because it only matches lowercases, numbers and dashes, any other character is replaced by the separator character, am I right?
Anyway, before changing it, how do you suggest to name it? I'm not very creative with this kind of names.

[florianeckerstorfer]

Ok, I get it. You meant LOWERCASE for characters, but it looks like it means lowercase numbers.

Currently I don't have a better suggestion, because optimally it would be precise and short. Anyway, the regular expression means match every character that is not a lowercase letter and not a number or that is a dash.

[acelaya]

Yes, its not very descriptive but I meant lowercase, numbers, dashes, not lowercase numbers, but I understand the confusion.
However, the name I chose (regardless typos) isn't completly correct, what do you think if I just change it to DEFAULT_REGEXP

[acelaya]

Finally named it LOWERCASE_NUMBERS_NOT_DASHES (like in lowercase letters, numbers and not dashes).
It's a little bit long, but I couldn't find a better name.

[coveralls]

Coverage decreased (-3.92%) when pulling b707292 on acelaya:feature/regexp into 9da3415 on cocur:master.

[acelaya]

Hmmm, it looks that the code coverage decreased. Let me fix it.

[coveralls]

Coverage remained the same when pulling 29e783f on acelaya:feature/regexp into 9da3415 on cocur:master.

[florianeckerstorfer]

Could you name the constant LOWERCASE_NUMBERS_DASHES. Because this regular expression generates a slug that contains lowercase letters, numbers and dashes.

[acelaya]

Done