Simplify params (#2925)

coda · Mar 6, 2024 · 4b0ddd4 · 4b0ddd4
1 parent 7f2a448
commit 4b0ddd4
Show file tree

Hide file tree

Showing 5 changed files with 31 additions and 33 deletions.
diff --git a/dist/testing/upload_validation.d.ts b/dist/testing/upload_validation.d.ts
diff --git a/dist/testing/upload_validation.js b/dist/testing/upload_validation.js
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@codahq/packs-sdk",
-  "version": "1.7.5",
+  "version": "1.7.6-prerelease.1",
   "license": "MIT",
   "workspaces": [
     "dev/eslint"

diff --git a/test/upload_validation_test.ts b/test/upload_validation_test.ts
@@ -2234,7 +2234,7 @@ describe('Pack metadata Validation', async () => {
             syncTables: [childTable, parentTable],
           });
           await validateJson(metadata);
-          const hierarchy = validateCrawlHierarchy(metadata);
+          const hierarchy = validateCrawlHierarchy(metadata.syncTables || []);
           assert.deepEqual(hierarchy, {Parent: ['Child']});
         });
 
@@ -2357,7 +2357,7 @@ describe('Pack metadata Validation', async () => {
             syncTables: [childTable, parentTable],
           });
           await validateJson(metadata);
-          const hierarchy = validateCrawlHierarchy(metadata);
+          const hierarchy = validateCrawlHierarchy(metadata.syncTables || []);
           assert.deepEqual(hierarchy, {Parent: ['Child']});
         });
 
@@ -2433,7 +2433,7 @@ describe('Pack metadata Validation', async () => {
               path: 'syncTables',
             },
           ]);
-          const hierarchy = validateCrawlHierarchy(metadata);
+          const hierarchy = validateCrawlHierarchy(metadata.syncTables || []);
           assert.isUndefined(hierarchy);
         });
 
@@ -2498,7 +2498,7 @@ describe('Pack metadata Validation', async () => {
               path: 'syncTables[0].parameters',
             },
           ]);
-          const hierarchy = validateCrawlHierarchy(metadata);
+          const hierarchy = validateCrawlHierarchy(metadata.syncTables || []);
           assert.isUndefined(hierarchy);
         });
       });

diff --git a/testing/upload_validation.ts b/testing/upload_validation.ts
@@ -235,14 +235,10 @@ export function validateSyncTableSchema(
  * @hidden
  */
 export function validateCrawlHierarchy(
-  pack: PackVersionDefinition,
+  syncTables: SyncTable[],
   context?: z.RefinementCtx,
 ): Record<string, string[]> | undefined {
   const parentToChildrenMap: Record<string, string[]> = {};
-  if (!pack.syncTables) {
-    return parentToChildrenMap;
-  }
-  const syncTables: SyncTable[] = pack.syncTables;
   const syncTableSchemasByName: Record<string, ObjectSchema<any, any>> = {};
   for (const syncTable of syncTables) {
     syncTableSchemasByName[syncTable.name] = syncTable.schema;
@@ -1376,7 +1372,7 @@ function buildMetadataSchema({sdkVersion}: BuildMetadataSchemaArgs): {
                 createdAtPropertySchema.codaType === ValueHintType.Date),
             `must refer to a "ValueType.String" or "ValueType.Number" property with a "ValueHintType.DateTime" or "ValueHintType.Date" "codaType".`,
           );
-        }
+        };
         const validateModifiedAtProperty = () => {
           return validateProperty(
             'modifiedAtProperty',
@@ -1387,26 +1383,26 @@ function buildMetadataSchema({sdkVersion}: BuildMetadataSchemaArgs): {
                 modifiedAtPropertySchema.codaType === ValueHintType.Date),
             `must refer to a "ValueType.String" or "ValueType.Number" property with a "ValueHintType.DateTime" or "ValueHintType.Date" "codaType".`,
           );
-        }
+        };
         const validateCreatedByProperty = () => {
           return validateProperty(
             'createdByProperty',
             createdByPropertySchema =>
-            (createdByPropertySchema.type === ValueType.Object
-              || createdByPropertySchema.type === ValueType.String) &&
-            (createdByPropertySchema.codaType === ValueHintType.Person
-              || createdByPropertySchema.codaType === ValueHintType.Email),
+              (createdByPropertySchema.type === ValueType.Object ||
+                createdByPropertySchema.type === ValueType.String) &&
+              (createdByPropertySchema.codaType === ValueHintType.Person ||
+                createdByPropertySchema.codaType === ValueHintType.Email),
             `must refer to a "ValueType.Object" or "ValueType.String" property with a "ValueHintType.Person" or "ValueHintType.Email" "codaType".`,
           );
         };
         const validateModifiedByProperty = () => {
           return validateProperty(
             'modifiedByProperty',
             modifiedByPropertySchema =>
-            (modifiedByPropertySchema.type === ValueType.Object ||
-              modifiedByPropertySchema.type === ValueType.String) &&
-            (modifiedByPropertySchema.codaType === ValueHintType.Person ||
-              modifiedByPropertySchema.codaType === ValueHintType.Email),
+              (modifiedByPropertySchema.type === ValueType.Object ||
+                modifiedByPropertySchema.type === ValueType.String) &&
+              (modifiedByPropertySchema.codaType === ValueHintType.Person ||
+                modifiedByPropertySchema.codaType === ValueHintType.Email),
             `must refer to a "ValueType.Object" or "ValueType.String" property with a "ValueHintType.Person" or "ValueHintType.Email" "codaType".`,
           );
         };
@@ -1865,7 +1861,10 @@ function buildMetadataSchema({sdkVersion}: BuildMetadataSchemaArgs): {
       });
     })
     .superRefine((data, context) => {
-      validateCrawlHierarchy(data as PackVersionDefinition, context);
+      const {syncTables} = data as PackVersionDefinition;
+      if (syncTables) {
+        validateCrawlHierarchy(syncTables, context);
+      }
     })
     .superRefine((data, context) => {
       ((data.formulas as any[]) || []).forEach((formula, i) => {