Fix XML handling when isBinaryResponse: true
#2525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekoleda-codaio
commented
Mar 13, 2023
| @@ -270,7 +270,7 @@ export class AuthenticatingFetcher implements Fetcher { | |||
| if (!this._credentials) { | |||
| throw new Error( | |||
| `${this._authDef.type} authentication is required for this pack, but no local credentials were found. ` + | |||
| 'Run "coda auth path/to/pack/manifest to set up credentials."', | |||
There was a problem hiding this comment.
I think my VSCode is handling these continued lines somewhat differently, but it lints fine. Is there something I can do to bring this in line with the rest of the team?
There was a problem hiding this comment.
Not sure, was seeing this with David's PRs too, it's weird.
I think there may be one or two people on the team who don't have prettier enabled in this repo or something and these changes wind up being us fixing up those spots?
jonathan-codaio
approved these changes
Mar 13, 2023
| @@ -270,7 +270,7 @@ export class AuthenticatingFetcher implements Fetcher { | |||
| if (!this._credentials) { | |||
| throw new Error( | |||
| `${this._authDef.type} authentication is required for this pack, but no local credentials were found. ` + | |||
| 'Run "coda auth path/to/pack/manifest to set up credentials."', | |||
There was a problem hiding this comment.
Not sure, was seeing this with David's PRs too, it's weird.
I think there may be one or two people on the team who don't have prettier enabled in this repo or something and these changes wind up being us fixing up those spots?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was fixed on the server in o/bug/27140, but was still broken in the testing fetcher used locally.