Fallback to counting lines when metrics fail ft 5698 #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this PR depends on this: #105 |
bmbferreira
force-pushed
the
fallback_to_counting_lines_when_metrics_fail_FT-5698
branch
3 times, most recently
from
2c8f5d8
to
96977d6
Compare
rtfpessoa
suggested changes
Sep 7, 2018
| }(collection.breakOut) | ||
| } | ||
|
|
||
| fileMetrics.foreach(results => formatter.addAll(results.to[List])) |
There was a problem hiding this comment.
calculateMissingFileMetrics doing the formatter does not seem a nice thing.
|
|
||
| val analysisFiles: Set[Path] = metricsResults.flatMap(_.files)(collection.breakOut) | ||
|
|
||
| metricsResults.map { res => |
There was a problem hiding this comment.
Can we try something like
forEach file
getMetrics
case None => FileMetrics(loc = calculateLoc)
case Some(metrics) if metrics.loc.isEmpty => FileMetrics(loc = calculateLoc)
case Some(metrics) => metrics
| analysisResultsWithMissingMetrics | ||
| } | ||
|
|
||
| private def reduceAndCalculateMissingFileMetrics( |
There was a problem hiding this comment.
Try to put this inside some post processing logic and then perform the reduce, missing and format inside.
|
This PR depends on this: #107 |
added 6 commits
September 10, 2018 09:42
…bsolute paths and to improve function composition.
* Removed unnecessary clone from unit test and added local file
bmbferreira
force-pushed
the
fallback_to_counting_lines_when_metrics_fail_FT-5698
branch
from
9b4b1be
to
851b9f3
Compare
bmbferreira
force-pushed
the
fallback_to_counting_lines_when_metrics_fail_FT-5698
branch
from
851b9f3
to
7d1a822
Compare
rtfpessoa
approved these changes
Sep 10, 2018
rtfpessoa
deleted the
fallback_to_counting_lines_when_metrics_fail_FT-5698
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.